chore: addressed PR feedback

Signed-off-by: Ben Selwyn-Smith <benselwynsmith@googlemail.com>

src/macaron/repo_finder/repo_finder.py

@@ -236,13 +236,6 @@ def get_tags_via_git_remote(repo: str) -> dict[str, str] | None:
     if not tag_data:
         return None
     tags = {}
-    # try:
-    #    command = git.cmd.Git()
-    # command.update_environment(GIT_TERMINAL_PROMPT="")
-    #    tag_data = command.ls_remote("--tags", repo)
-    # except git.exc.GitCommandError as error:
-    #    logger.debug("Failed to retrieve tags: %s", error)
-    #    return None
 
     for tag_line in tag_data.splitlines():
         tag_line = tag_line.strip()

src/macaron/slsa_analyzer/git_url.py

@@ -408,9 +408,11 @@ def list_remote_references(arguments: list[str], repo: str) -> str | None:
     if result.returncode != 0:
         error_string = result.stderr.decode("utf-8").strip()
         if error_string.startswith("fatal: could not read Username"):
-            # Occurs when a repository cannot be accesses either because it does not exist, or it requires a login
+            # Occurs when a repository cannot be accessed either because it does not exist, or it requires a login
             # that is blocked.
             logger.error("Could not access repository: %s", repo)
+        else:
+            logger.error("Failed to retrieve remote references from repo: %s", repo)
         return None
 
     return result.stdout.decode("utf-8")

tests/integration/cases/find_source_fail/test.yaml

@@ -2,7 +2,7 @@
 # Licensed under the Universal Permissive License v 1.0 as shown at https://oss.oracle.com/licenses/upl/.
 
 description: |
-  Analyzing the find source command on the a non-existent repository.
+  Analyzing the find source command on a non-existent repository.
 
 tags:
 - macaron-python-package