Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WMS 11825 - first version #367

Merged
merged 67 commits into from
Feb 4, 2025
Merged

Conversation

MarcGueury
Copy link
Contributor

Add here your WMS 11825

General requirements

  1. Information in the workshop is adequate and updated
  2. Code is correct and working
  3. Links are correct
  4. Make sure you enter the help email link in your manifest.json
  5. Please make sure WMS URLs are updated as needed after your PR is approved

Checklist - Refer to the QA document for the complete list

Please confirm that the following is completed before submitting your PR

  • All filenames are lower case (including folders, images, files, etc.)
  • Filenames are descriptive
  • Your workshop folder structure should be similar to the one used in the sample workshop (https://github.com/oracle-livelabs/common/tree/main/sample-livelabs-templates/sample-workshop)
  • Are you using multiple versions (desktop/, sandbox/, tenancy/)? Make sure that each of them contains a manifest.json and an index.html
  • Image references in markdown contain an alternate text

Copy link

@carmenberdant1 carmenberdant1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @MarcGueury, for lab 4 please have the image names in lowercase and modify them in the digital-assistant.md file too. Additionally, this branch is out of date, please update it from the main.
Thank you!

@MarcGueury
Copy link
Contributor Author

I did this:

  • updated files of lab4 with all lowercase
  • modified digital-assistant.md to reflect it
  • sync this branch with main

Thanks, please review.

@MarcGueury
Copy link
Contributor Author

@carmenberdant1

@carmenberdant1 carmenberdant1 merged commit 39763a4 into oracle-livelabs:main Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants