Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bundle optuna_dashboard into jupyterlab extension's package #1037

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

c-bata
Copy link
Member

@c-bata c-bata commented Feb 18, 2025

Contributor License Agreement

This repository (optuna-dashboard) and Goptuna share common code.
This pull request may therefore be ported to Goptuna.
Make sure that you understand the consequences concerning licenses and check the box below if you accept the term before creating this pull request.

  • I agree this patch may be ported to Goptuna by other Goptuna contributors.

Reference Issues/PRs

None

What does this implement/fix? Explain your changes.

Currently, Jupyter Lab extension depends on the optuna-dashboard package. So we cannot introduce breaking changes on JSON APIs. This PR bundles the source code of optuna_dashboard package into the JupyterLab extension's distribution package.

Copy link

codecov bot commented Feb 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.16%. Comparing base (a0a7191) to head (9067408).
Report is 12 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1037   +/-   ##
=======================================
  Coverage   70.16%   70.16%           
=======================================
  Files          35       35           
  Lines        2400     2400           
=======================================
  Hits         1684     1684           
  Misses        716      716           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant