Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove DisableAccessibilityCheck #5679

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

jainv4156
Copy link
Contributor

@jainv4156 jainv4156 commented Jan 30, 2025

Explanation

fixes: #3245

Essential Checklist

  • The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)

  • Any changes to scripts/assets files have their rationale included in the PR explanation.

  • The PR follows the style guide.

  • The PR does not contain any unnecessary code changes from Android Studio (reference).

  • The PR is made from a branch that's not called "develop" and is up-to-date with "develop".

  • The PR is assigned to the appropriate reviewers (reference).

  • StoryFragmentTest.kt
    image

  • StoryActivityTest.kt
    image

  • CreateProfileFragmentTest.kt
    image

@jainv4156 jainv4156 requested a review from a team as a code owner January 30, 2025 08:59
Copy link

Coverage Report

Results

Number of files assessed: 3
Overall Coverage: 0.00%
Coverage Analysis: PASS

Exempted coverage

Files exempted from coverage
File Exemption Reason
StoryActivity.ktapp/src/main/java/org/oppia/android/app/story/StoryActivity.kt
This file is incompatible with code coverage tooling; skipping coverage check.
StoryFragment.ktapp/src/main/java/org/oppia/android/app/story/StoryFragment.kt
This file is incompatible with code coverage tooling; skipping coverage check.
CreateProfileFragment.ktapp/src/main/java/org/oppia/android/app/onboarding/CreateProfileFragment.kt
This file is incompatible with code coverage tooling; skipping coverage check.

Refer test_file_exemptions.textproto for the comprehensive list of file exemptions and their required coverage percentages.

To learn more, visit the Oppia Android Code Coverage wiki page

@jainv4156
Copy link
Contributor Author

@adhiamboperes PTAL , thanks!

@oppiabot oppiabot bot assigned adhiamboperes and unassigned jainv4156 Jan 30, 2025
Copy link

oppiabot bot commented Jan 30, 2025

Unassigning @jainv4156 since a re-review was requested. @jainv4156, please make sure you have addressed all review comments. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[A11y] Enable AccessibilityChecks
2 participants