Fix Part of #4236 : Add tests for AsyncResultSubject #5670

TanishMoral11 · 2025-01-26T22:34:31Z

Explanation

Fixes part of #4236: Adds tests to ensure correct handling of non-iterable async results.

This PR adds tests for the AsyncResultSubject class. It verifies that the AsyncResultSubject handles non-iterable results correctly and ensures that the expected failures occur when the result is not iterable. The test specifically checks that the appropriate behavior is triggered when a non-iterable result is provided.

Essential Checklist

The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
Any changes to scripts/assets files have their rationale included in the PR explanation.
The PR follows the style guide.
The PR does not contain any unnecessary code changes from Android Studio (reference).
The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
The PR is assigned to the appropriate reviewers (reference).

TanishMoral11 · 2025-01-27T10:47:12Z

Hey @adhiamboperes PTAL, and suggest me if there are any changes to make.

TanishMoral11 · 2025-01-27T10:48:42Z

Hey @adhiamboperes, PTAL !!

github-actions · 2025-01-27T11:57:19Z

Coverage Report

Results

Number of files assessed: 3
Overall Coverage: 89.81%
Coverage Analysis: PASS ✅

Passing coverage

Files with passing code coverage

File	Coverage	Lines Hit	Status	Min Required
MathTagHandler.kt utility/src/main/java/org/oppia/android/util/parser/html/MathTagHandler.kt	89.81%	97 / 108	✅	70%

Exempted coverage

Files exempted from coverage

File	Exemption Reason
StateRetriever.kt domain/src/main/java/org/oppia/android/domain/util/StateRetriever.kt	This file is incompatible with code coverage tooling; skipping coverage check.
AsyncResultSubject.kt testing/src/main/java/org/oppia/android/testing/data/AsyncResultSubject.kt	This file is exempted from having a test file; skipping coverage check.

Refer test_file_exemptions.textproto for the comprehensive list of file exemptions and their required coverage percentages.

To learn more, visit the Oppia Android Code Coverage wiki page

github-actions · 2025-01-27T16:29:46Z

Coverage Report

Results

Number of files assessed: 1
Overall Coverage: 0.00%
Coverage Analysis: PASS ✅

Exempted coverage

Files exempted from coverage

File	Exemption Reason
AsyncResultSubject.kt testing/src/main/java/org/oppia/android/testing/data/AsyncResultSubject.kt	This file is exempted from having a test file; skipping coverage check.

Refer test_file_exemptions.textproto for the comprehensive list of file exemptions and their required coverage percentages.

To learn more, visit the Oppia Android Code Coverage wiki page

TanishMoral11 · 2025-01-28T18:11:30Z

Hey @adhiamboperes , could you please take a look ?

Thanks !!

adhiamboperes

Thanks @TanishMoral11!
I noticed that you have not fully tested the class. Additionally, please rename the tests following the pattern that I have suggested.

adhiamboperes · 2025-01-30T08:40:50Z

testing/src/test/java/org/oppia/android/testing/data/BUILD.bazel

@@ -33,3 +33,21 @@ oppia_android_test(
        "//utility/src/main/java/org/oppia/android/util/networking:debug_module",
    ],
 )
+
+# Adding test for AsyncResultSubject


This comment is not required.

adhiamboperes · 2025-01-30T08:47:21Z

testing/src/main/java/org/oppia/android/testing/data/AsyncResultSubject.kt

remove this file from test_file_exemptions

adhiamboperes · 2025-01-30T08:48:12Z

testing/src/test/java/org/oppia/android/testing/data/AsyncResultSubjectTest.kt

+import org.oppia.android.util.data.AsyncResult
+import org.robolectric.RobolectricTestRunner
+
+@RunWith(RobolectricTestRunner::class)


Suggested change

@RunWith(RobolectricTestRunner::class)

@RunWith(JUnit4::class)

adhiamboperes · 2025-01-30T08:51:40Z

testing/src/test/java/org/oppia/android/testing/data/AsyncResultSubjectTest.kt

+class AsyncResultSubjectTest {
+
+  @Test
+  fun testAsyncResultPending_isPending() {


Suggested change

fun testAsyncResultPending_isPending() {

fun testAsyncResultSubject_pendingResult_checkIsPending() {

adhiamboperes · 2025-01-30T08:53:24Z

testing/src/test/java/org/oppia/android/testing/data/AsyncResultSubjectTest.kt

+  }
+
+  @Test
+  fun testAsyncResultPending_isNotSuccess() {


Suggested change

fun testAsyncResultPending_isNotSuccess() {

fun testAsyncResultSubject_pendingResult_checkIsNotSuccess() {

You are also missing a corresponding "isNotFailure()" test.

adhiamboperes · 2025-01-30T09:00:54Z

testing/src/test/java/org/oppia/android/testing/data/AsyncResultSubjectTest.kt

+  @Test
+  fun testAsyncResultSuccess_hasSuccessValueWhere_matchesExpected() {
+    val successResult: AsyncResult<String> = AsyncResult.Success("Success value")
+
+    AsyncResultSubject.assertThat(successResult).hasSuccessValueWhere {
+      // Here we are verifying that the value is "Success value"
+      assertThat(this).isEqualTo("Success value")
+    }
+  }


Suggestion to reduce ambiguity.

Suggested change

@Test

fun testAsyncResultSuccess_hasSuccessValueWhere_matchesExpected() {

val successResult: AsyncResult<String> = AsyncResult.Success("Success value")

AsyncResultSubject.assertThat(successResult).hasSuccessValueWhere {

// Here we are verifying that the value is "Success value"

assertThat(this).isEqualTo("Success value")

}

}

@Test

fun testAsyncResultSuccess_hasSuccessValueWhere_matchesExpected() {

val successResult: AsyncResult<String> = AsyncResult.Success("Some string")

AsyncResultSubject.assertThat(successResult).hasSuccessValueWhere { result ->

assertThat(result).isEqualTo("Some string")

}

}

github-actions · 2025-01-30T18:28:20Z

Coverage Report

Results

Coverage Analysis: SKIP ⏭️

This PR did not introduce any changes to Kotlin source or test files.

To learn more, visit the Oppia Android Code Coverage wiki page

TanishMoral11 added 5 commits January 27, 2025 03:53

Added Test For AsyncResultSubject

c009a17

Reformatting

9dfebea

Update

8b98691

Added New Tests

000ca24

Reformatting

6ab4e6d

TanishMoral11 marked this pull request as ready for review January 27, 2025 10:48

TanishMoral11 requested review from a team as code owners January 27, 2025 10:48

TanishMoral11 requested a review from adhiamboperes January 27, 2025 10:48

oppiabot bot assigned adhiamboperes Jan 27, 2025

TanishMoral11 and others added 2 commits January 27, 2025 18:42

Resolved Klint Issue

ae62e88

Merge branch 'develop' into add-tests-for-asyncresultsubject

bad8e9a

Merge branch 'develop' into add-tests-for-asyncresultsubject

d297385

adhiamboperes changed the title ~~Fix #4236 : Add tests for AsyncResultSubject~~ Fix Part of #4236 : Add tests for AsyncResultSubject Jan 30, 2025

adhiamboperes requested changes Jan 30, 2025

View reviewed changes

adhiamboperes assigned TanishMoral11 and unassigned adhiamboperes Jan 30, 2025

TanishMoral11 added 5 commits January 30, 2025 19:33

Added More Tests

aa623bc

Format

200f7e0

All Test

36195e7

Rerun CI Checks

e387066

Klint

a4ae9d8

All Tests

c1f1521

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix Part of #4236 : Add tests for AsyncResultSubject #5670

Fix Part of #4236 : Add tests for AsyncResultSubject #5670

TanishMoral11 commented Jan 26, 2025 •

edited by adhiamboperes

Loading

TanishMoral11 commented Jan 27, 2025

TanishMoral11 commented Jan 27, 2025

github-actions bot commented Jan 27, 2025

github-actions bot commented Jan 27, 2025

TanishMoral11 commented Jan 28, 2025

adhiamboperes left a comment

adhiamboperes Jan 30, 2025

TanishMoral11 Jan 30, 2025

adhiamboperes Jan 30, 2025

TanishMoral11 Jan 30, 2025

adhiamboperes Jan 30, 2025

adhiamboperes Jan 30, 2025

TanishMoral11 Jan 30, 2025

adhiamboperes Jan 30, 2025

adhiamboperes Jan 30, 2025

adhiamboperes Jan 30, 2025

github-actions bot commented Jan 30, 2025

	@RunWith(RobolectricTestRunner::class)
	@RunWith(JUnit4::class)

	fun testAsyncResultPending_isPending() {
	fun testAsyncResultSubject_pendingResult_checkIsPending() {

	fun testAsyncResultPending_isNotSuccess() {
	fun testAsyncResultSubject_pendingResult_checkIsNotSuccess() {

Fix Part of #4236 : Add tests for AsyncResultSubject #5670

Are you sure you want to change the base?

Fix Part of #4236 : Add tests for AsyncResultSubject #5670

Conversation

TanishMoral11 commented Jan 26, 2025 • edited by adhiamboperes Loading

Explanation

Essential Checklist

TanishMoral11 commented Jan 27, 2025

TanishMoral11 commented Jan 27, 2025

github-actions bot commented Jan 27, 2025

Coverage Report

Results

Passing coverage

Exempted coverage

github-actions bot commented Jan 27, 2025

Coverage Report

Results

Exempted coverage

TanishMoral11 commented Jan 28, 2025

adhiamboperes left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented Jan 30, 2025

Coverage Report

Results

TanishMoral11 commented Jan 26, 2025 •

edited by adhiamboperes

Loading