-
Notifications
You must be signed in to change notification settings - Fork 536
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #4121: Added tests for TokenSubject #5669
base: develop
Are you sure you want to change the base?
Conversation
Coverage ReportResultsNumber of files assessed: 1 Exempted coverageFiles exempted from coverage
|
Hi @adhiamboperes PTAL, and suggest me if there are any changes to make. |
APK & AAB differences analysisNote that this is a summarized snapshot. See the CI artifacts for detailed differences. DevExpand to see flavor specificsUniversal APKAPK file size: 19 MiB (old), 19 MiB (new), 0 bytes (No change) APK download size (estimated): 17 MiB (old), 17 MiB (new), 1 bytes (Added) Method count: 260263 (old), 260263 (new), 0 (No change) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 6820 (old), 6820 (new), 0 (No change)
Lesson assets: 111 (old), 111 (new), 0 (No change) AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 18 MiB (old), 18 MiB (new), 0 bytes (No change) Configuration hdpiAPK file size: 50 KiB (old), 50 KiB (new), 0 bytes (No change) Configuration ldpiAPK file size: 49 KiB (old), 49 KiB (new), 0 bytes (No change) Configuration mdpiAPK file size: 45 KiB (old), 45 KiB (new), 0 bytes (No change) Configuration tvdpiAPK file size: 86 KiB (old), 86 KiB (new), 0 bytes (No change) Configuration xhdpiAPK file size: 57 KiB (old), 57 KiB (new), 0 bytes (No change) Configuration xxhdpiAPK file size: 63 KiB (old), 63 KiB (new), 0 bytes (No change) Configuration xxxhdpiAPK file size: 63 KiB (old), 63 KiB (new), 0 bytes (No change) AlphaExpand to see flavor specificsUniversal APKAPK file size: 11 MiB (old), 11 MiB (new), 0 bytes (No change) APK download size (estimated): 10 MiB (old), 10 MiB (new), 1 bytes (Added) Method count: 115793 (old), 115793 (new), 0 (No change) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 5788 (old), 5788 (new), 0 (No change)
Lesson assets: 111 (old), 111 (new), 0 (No change) AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 11 MiB (old), 11 MiB (new), 4 bytes (Added) Configuration hdpiAPK file size: 43 KiB (old), 43 KiB (new), 0 bytes (No change) Configuration ldpiAPK file size: 44 KiB (old), 44 KiB (new), 0 bytes (No change) Configuration mdpiAPK file size: 38 KiB (old), 38 KiB (new), 0 bytes (No change) Configuration tvdpiAPK file size: 73 KiB (old), 73 KiB (new), 0 bytes (No change) Configuration xhdpiAPK file size: 50 KiB (old), 50 KiB (new), 0 bytes (No change) Configuration xxhdpiAPK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change) Configuration xxxhdpiAPK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change) BetaExpand to see flavor specificsUniversal APKAPK file size: 11 MiB (old), 11 MiB (new), 4 bytes (Removed) APK download size (estimated): 10 MiB (old), 10 MiB (new), 25 bytes (Added) Method count: 115799 (old), 115799 (new), 0 (No change) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 5788 (old), 5788 (new), 0 (No change)
Lesson assets: 111 (old), 111 (new), 0 (No change) AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 10 MiB (old), 10 MiB (new), 4 bytes (Removed) Configuration hdpiAPK file size: 43 KiB (old), 43 KiB (new), 0 bytes (No change) Configuration ldpiAPK file size: 44 KiB (old), 44 KiB (new), 0 bytes (No change) Configuration mdpiAPK file size: 38 KiB (old), 38 KiB (new), 0 bytes (No change) Configuration tvdpiAPK file size: 73 KiB (old), 73 KiB (new), 0 bytes (No change) Configuration xhdpiAPK file size: 50 KiB (old), 50 KiB (new), 0 bytes (No change) Configuration xxhdpiAPK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change) Configuration xxxhdpiAPK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change) GaExpand to see flavor specificsUniversal APKAPK file size: 11 MiB (old), 11 MiB (new), 8 bytes (Added) APK download size (estimated): 10 MiB (old), 10 MiB (new), 13 bytes (Added) Method count: 115799 (old), 115799 (new), 0 (No change) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 5788 (old), 5788 (new), 0 (No change)
Lesson assets: 111 (old), 111 (new), 0 (No change) AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 10 MiB (old), 10 MiB (new), 8 bytes (Added) Configuration hdpiAPK file size: 43 KiB (old), 43 KiB (new), 0 bytes (No change) Configuration ldpiAPK file size: 44 KiB (old), 44 KiB (new), 0 bytes (No change) Configuration mdpiAPK file size: 38 KiB (old), 38 KiB (new), 0 bytes (No change) Configuration tvdpiAPK file size: 73 KiB (old), 73 KiB (new), 0 bytes (No change) Configuration xhdpiAPK file size: 50 KiB (old), 50 KiB (new), 0 bytes (No change) Configuration xxhdpiAPK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change) Configuration xxxhdpiAPK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change) |
APK & AAB differences analysisNote that this is a summarized snapshot. See the CI artifacts for detailed differences. DevExpand to see flavor specificsUniversal APKAPK file size: 19 MiB (old), 19 MiB (new), 3820 bytes (Removed) APK download size (estimated): 17 MiB (old), 17 MiB (new), 2550 bytes (Removed) Method count: 260301 (old), 260280 (new), 21 (Removed) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 6830 (old), 6820 (new), 10 (Removed)
Lesson assets: 111 (old), 111 (new), 0 (No change) AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 18 MiB (old), 18 MiB (new), 3816 bytes (Removed)
Configuration hdpiAPK file size: 50 KiB (old), 50 KiB (new), 8 bytes (Removed) Configuration ldpiAPK file size: 49 KiB (old), 49 KiB (new), 0 bytes (No change) Configuration mdpiAPK file size: 45 KiB (old), 45 KiB (new), 0 bytes (No change) Configuration tvdpiAPK file size: 86 KiB (old), 86 KiB (new), 8 bytes (Removed) Configuration xhdpiAPK file size: 57 KiB (old), 57 KiB (new), 8 bytes (Removed) Configuration xxhdpiAPK file size: 63 KiB (old), 63 KiB (new), 8 bytes (Removed) Configuration xxxhdpiAPK file size: 63 KiB (old), 63 KiB (new), 8 bytes (Removed) AlphaExpand to see flavor specificsUniversal APKAPK file size: 11 MiB (old), 11 MiB (new), 1376 bytes (Removed) APK download size (estimated): 10 MiB (old), 10 MiB (new), 1700 bytes (Removed) Method count: 115824 (old), 115808 (new), 16 (Removed) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 5798 (old), 5788 (new), 10 (Removed)
Lesson assets: 111 (old), 111 (new), 0 (No change) AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 11 MiB (old), 11 MiB (new), 1368 bytes (Removed)
Configuration hdpiAPK file size: 43 KiB (old), 43 KiB (new), 8 bytes (Removed) Configuration ldpiAPK file size: 44 KiB (old), 44 KiB (new), 0 bytes (No change) Configuration mdpiAPK file size: 38 KiB (old), 38 KiB (new), 0 bytes (No change) Configuration tvdpiAPK file size: 73 KiB (old), 73 KiB (new), 8 bytes (Removed) Configuration xhdpiAPK file size: 50 KiB (old), 50 KiB (new), 8 bytes (Removed) Configuration xxhdpiAPK file size: 55 KiB (old), 55 KiB (new), 8 bytes (Removed) Configuration xxxhdpiAPK file size: 55 KiB (old), 55 KiB (new), 8 bytes (Removed) BetaExpand to see flavor specificsUniversal APKAPK file size: 11 MiB (old), 11 MiB (new), 1560 bytes (Removed) APK download size (estimated): 10 MiB (old), 10 MiB (new), 625 bytes (Removed) Method count: 115830 (old), 115814 (new), 16 (Removed) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 5798 (old), 5788 (new), 10 (Removed)
Lesson assets: 111 (old), 111 (new), 0 (No change) AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 10 MiB (old), 10 MiB (new), 1552 bytes (Removed)
Configuration hdpiAPK file size: 43 KiB (old), 43 KiB (new), 8 bytes (Removed) Configuration ldpiAPK file size: 44 KiB (old), 44 KiB (new), 0 bytes (No change) Configuration mdpiAPK file size: 38 KiB (old), 38 KiB (new), 0 bytes (No change) Configuration tvdpiAPK file size: 73 KiB (old), 73 KiB (new), 8 bytes (Removed) Configuration xhdpiAPK file size: 50 KiB (old), 50 KiB (new), 8 bytes (Removed) Configuration xxhdpiAPK file size: 55 KiB (old), 55 KiB (new), 8 bytes (Removed) Configuration xxxhdpiAPK file size: 55 KiB (old), 55 KiB (new), 8 bytes (Removed) GaExpand to see flavor specificsUniversal APKAPK file size: 11 MiB (old), 11 MiB (new), 1704 bytes (Removed) APK download size (estimated): 10 MiB (old), 10 MiB (new), 821 bytes (Removed) Method count: 115830 (old), 115814 (new), 16 (Removed) Features: 2 (old), 2 (new), 0 (No change) Permissions: 6 (old), 6 (new), 0 (No change) Resources: 5798 (old), 5788 (new), 10 (Removed)
Lesson assets: 111 (old), 111 (new), 0 (No change) AAB differencesExpand to see AAB specificsSupported configurations:
Base APKAPK file size: 10 MiB (old), 10 MiB (new), 1692 bytes (Removed)
Configuration hdpiAPK file size: 43 KiB (old), 43 KiB (new), 8 bytes (Removed) Configuration ldpiAPK file size: 44 KiB (old), 44 KiB (new), 0 bytes (No change) Configuration mdpiAPK file size: 38 KiB (old), 38 KiB (new), 0 bytes (No change) Configuration tvdpiAPK file size: 73 KiB (old), 73 KiB (new), 8 bytes (Removed) Configuration xhdpiAPK file size: 50 KiB (old), 50 KiB (new), 8 bytes (Removed) Configuration xxhdpiAPK file size: 55 KiB (old), 55 KiB (new), 8 bytes (Removed) Configuration xxxhdpiAPK file size: 55 KiB (old), 55 KiB (new), 8 bytes (Removed) |
Fixes #4121
This pull request introduces a new test class
TokenSubjectTest
to theoppia_android_test
suite, focusing on validating various aspects of theToken
class from theMathTokenizer
utility. The primary changes include the addition of the test class itself and the corresponding Bazel build rule.Key Changes:
Addition of Test Class:
testing/src/test/java/org/oppia/android/testing/math/TokenSubjectTest.kt
: Added a new test classTokenSubjectTest
with multiple test methods to verify the correctness of differentToken
types and their properties.Bazel Build Rule:
testing/src/test/java/org/oppia/android/testing/math/BUILD.bazel
: Added a newoppia_android_test
target forTokenSubjectTest
, specifying its dependencies and configuration.Screenshot of the passing tests.
Essential Checklist