Fix #5406: Migrate keyboard hiding functionality #5463

subhajitxyz · 2024-07-13T09:50:23Z

Explanation

Replaced deprecated InputMethodManager.SHOW_FORCED with '0' flag to ensure compatibility with SDK 33.
Updated the following files:
    StateFragmentPresenter.kt
    SurveyFragmentPresenter.kt
    QuestionPlayerFragmentPresenter.kt
These changes ensure that the keyboard hides as expected across the app scenarios, maintaining the intended behavior.

Essential Checklist

The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
Any changes to scripts/assets files have their rationale included in the PR explanation.
The PR follows the style guide.
The PR does not contain any unnecessary code changes from Android Studio (reference).
The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
The PR is assigned to the appropriate reviewers (reference).

github-actions · 2024-07-13T09:50:37Z

Hi! @subhajitxyz Welcome to Oppia! Could you please follow the instructions here and sign the CLA Sheet to get started? You'll need to do this before we can accept your PR. Thanks!

github-actions · 2024-07-14T03:10:29Z

APK & AAB differences analysis

Note that this is a summarized snapshot. See the CI artifacts for detailed differences.

Dev

Expand to see flavor specifics

Universal APK

APK file size: 19 MiB (old), 19 MiB (new), 344 bytes (Removed)

APK download size (estimated): 17 MiB (old), 17 MiB (new), 99 bytes (Added)

Method count: 258445 (old), 258446 (new), 1 (Added)

Features: 2 (old), 2 (new), 0 (No change)

Permissions: 6 (old), 6 (new), 0 (No change)

Resources: 6775 (old), 6775 (new), 0 (No change)

Anim: 43 (old), 43 (new), 0 (No change)
Animator: 26 (old), 26 (new), 0 (No change)
Array: 15 (old), 15 (new), 0 (No change)
Attr: 922 (old), 922 (new), 0 (No change)
Bool: 9 (old), 9 (new), 0 (No change)
Color: 954 (old), 954 (new), 0 (No change)
Dimen: 1030 (old), 1030 (new), 0 (No change)
Drawable: 378 (old), 378 (new), 0 (No change)
Id: 1271 (old), 1271 (new), 0 (No change)
Integer: 37 (old), 37 (new), 0 (No change)
Interpolator: 11 (old), 11 (new), 0 (No change)
Layout: 378 (old), 378 (new), 0 (No change)
Menu: 3 (old), 3 (new), 0 (No change)
Mipmap: 1 (old), 1 (new), 0 (No change)
Plurals: 10 (old), 10 (new), 0 (No change)
Raw: 2 (old), 2 (new), 0 (No change)
String: 848 (old), 848 (new), 0 (No change)
Style: 831 (old), 831 (new), 0 (No change)
Xml: 6 (old), 6 (new), 0 (No change)

Lesson assets: 111 (old), 111 (new), 0 (No change)

AAB differences

Expand to see AAB specifics

Supported configurations:

hdpi (same)
ldpi (same)
mdpi (same)
tvdpi (same)
xhdpi (same)
xxhdpi (same)
xxxhdpi (same)

Base APK

APK file size: 18 MiB (old), 18 MiB (new), 344 bytes (Removed)
APK download size (estimated): 17 MiB (old), 17 MiB (new), 169 bytes (Added)
Method count: 258445 (old), 258446 (new), 1 (Added)

Configuration hdpi

APK file size: 49 KiB (old), 49 KiB (new), 0 bytes (No change)
APK download size (estimated): 18 KiB (old), 18 KiB (new), 0 bytes (No change)

Configuration ldpi

APK file size: 48 KiB (old), 48 KiB (new), 0 bytes (No change)
APK download size (estimated): 14 KiB (old), 14 KiB (new), 0 bytes (No change)

Configuration mdpi

APK file size: 45 KiB (old), 45 KiB (new), 0 bytes (No change)
APK download size (estimated): 14 KiB (old), 14 KiB (new), 0 bytes (No change)

Configuration tvdpi

APK file size: 85 KiB (old), 85 KiB (new), 0 bytes (No change)
APK download size (estimated): 29 KiB (old), 29 KiB (new), 0 bytes (No change)

Configuration xhdpi

APK file size: 56 KiB (old), 56 KiB (new), 0 bytes (No change)
APK download size (estimated): 21 KiB (old), 21 KiB (new), 0 bytes (No change)

Configuration xxhdpi

APK file size: 62 KiB (old), 62 KiB (new), 0 bytes (No change)
APK download size (estimated): 29 KiB (old), 29 KiB (new), 0 bytes (No change)

Configuration xxxhdpi

APK file size: 63 KiB (old), 63 KiB (new), 0 bytes (No change)
APK download size (estimated): 28 KiB (old), 28 KiB (new), 0 bytes (No change)

Alpha

Expand to see flavor specifics

Universal APK

APK file size: 11 MiB (old), 11 MiB (new), 88 bytes (Removed)

APK download size (estimated): 10 MiB (old), 10 MiB (new), 144 bytes (Removed)

Method count: 114844 (old), 114845 (new), 1 (Added)

Features: 2 (old), 2 (new), 0 (No change)

Permissions: 6 (old), 6 (new), 0 (No change)

Resources: 5745 (old), 5745 (new), 0 (No change)

Anim: 33 (old), 33 (new), 0 (No change)
Animator: 24 (old), 24 (new), 0 (No change)
Array: 14 (old), 14 (new), 0 (No change)
Attr: 888 (old), 888 (new), 0 (No change)
Bool: 8 (old), 8 (new), 0 (No change)
Color: 806 (old), 806 (new), 0 (No change)
Dimen: 765 (old), 765 (new), 0 (No change)
Drawable: 340 (old), 340 (new), 0 (No change)
Id: 1217 (old), 1217 (new), 0 (No change)
Integer: 32 (old), 32 (new), 0 (No change)
Interpolator: 11 (old), 11 (new), 0 (No change)
Layout: 341 (old), 341 (new), 0 (No change)
Menu: 1 (old), 1 (new), 0 (No change)
Mipmap: 1 (old), 1 (new), 0 (No change)
Plurals: 10 (old), 10 (new), 0 (No change)
String: 781 (old), 781 (new), 0 (No change)
Style: 472 (old), 472 (new), 0 (No change)
Xml: 1 (old), 1 (new), 0 (No change)

Lesson assets: 111 (old), 111 (new), 0 (No change)

AAB differences

Expand to see AAB specifics

Supported configurations:

hdpi (same)
ldpi (same)
mdpi (same)
tvdpi (same)
xhdpi (same)
xxhdpi (same)
xxxhdpi (same)

Base APK

APK file size: 10 MiB (old), 10 MiB (new), 88 bytes (Removed)
APK download size (estimated): 9 MiB (old), 9 MiB (new), 127 bytes (Removed)
Method count: 114844 (old), 114845 (new), 1 (Added)

Configuration hdpi

APK file size: 43 KiB (old), 43 KiB (new), 0 bytes (No change)
APK download size (estimated): 17 KiB (old), 17 KiB (new), 0 bytes (No change)

Configuration ldpi

APK file size: 44 KiB (old), 44 KiB (new), 0 bytes (No change)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 0 bytes (No change)

Configuration mdpi

APK file size: 38 KiB (old), 38 KiB (new), 0 bytes (No change)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 0 bytes (No change)

Configuration tvdpi

APK file size: 72 KiB (old), 72 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)

Configuration xhdpi

APK file size: 49 KiB (old), 49 KiB (new), 0 bytes (No change)
APK download size (estimated): 20 KiB (old), 20 KiB (new), 0 bytes (No change)

Configuration xxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change)
APK download size (estimated): 28 KiB (old), 28 KiB (new), 0 bytes (No change)

Configuration xxxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)

Beta

Expand to see flavor specifics

Universal APK

APK file size: 11 MiB (old), 11 MiB (new), 100 bytes (Removed)

APK download size (estimated): 10 MiB (old), 10 MiB (new), 728 bytes (Added)

Method count: 114850 (old), 114851 (new), 1 (Added)

Features: 2 (old), 2 (new), 0 (No change)

Permissions: 6 (old), 6 (new), 0 (No change)

Resources: 5745 (old), 5745 (new), 0 (No change)

Anim: 33 (old), 33 (new), 0 (No change)
Animator: 24 (old), 24 (new), 0 (No change)
Array: 14 (old), 14 (new), 0 (No change)
Attr: 888 (old), 888 (new), 0 (No change)
Bool: 8 (old), 8 (new), 0 (No change)
Color: 806 (old), 806 (new), 0 (No change)
Dimen: 765 (old), 765 (new), 0 (No change)
Drawable: 340 (old), 340 (new), 0 (No change)
Id: 1217 (old), 1217 (new), 0 (No change)
Integer: 32 (old), 32 (new), 0 (No change)
Interpolator: 11 (old), 11 (new), 0 (No change)
Layout: 341 (old), 341 (new), 0 (No change)
Menu: 1 (old), 1 (new), 0 (No change)
Mipmap: 1 (old), 1 (new), 0 (No change)
Plurals: 10 (old), 10 (new), 0 (No change)
String: 781 (old), 781 (new), 0 (No change)
Style: 472 (old), 472 (new), 0 (No change)
Xml: 1 (old), 1 (new), 0 (No change)

Lesson assets: 111 (old), 111 (new), 0 (No change)

AAB differences

Expand to see AAB specifics

Supported configurations:

hdpi (same)
ldpi (same)
mdpi (same)
tvdpi (same)
xhdpi (same)
xxhdpi (same)
xxxhdpi (same)

Base APK

APK file size: 10 MiB (old), 10 MiB (new), 100 bytes (Removed)
APK download size (estimated): 9 MiB (old), 9 MiB (new), 8 bytes (Added)
Method count: 114850 (old), 114851 (new), 1 (Added)

Configuration hdpi

APK file size: 43 KiB (old), 43 KiB (new), 0 bytes (No change)
APK download size (estimated): 17 KiB (old), 17 KiB (new), 0 bytes (No change)

Configuration ldpi

APK file size: 44 KiB (old), 44 KiB (new), 0 bytes (No change)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 0 bytes (No change)

Configuration mdpi

APK file size: 38 KiB (old), 38 KiB (new), 0 bytes (No change)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 0 bytes (No change)

Configuration tvdpi

APK file size: 72 KiB (old), 72 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)

Configuration xhdpi

APK file size: 49 KiB (old), 49 KiB (new), 0 bytes (No change)
APK download size (estimated): 20 KiB (old), 20 KiB (new), 0 bytes (No change)

Configuration xxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change)
APK download size (estimated): 28 KiB (old), 28 KiB (new), 0 bytes (No change)

Configuration xxxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)

Ga

Expand to see flavor specifics

Universal APK

APK file size: 11 MiB (old), 11 MiB (new), 60 bytes (Removed)

APK download size (estimated): 10 MiB (old), 10 MiB (new), 844 bytes (Added)

Method count: 114850 (old), 114851 (new), 1 (Added)

Features: 2 (old), 2 (new), 0 (No change)

Permissions: 6 (old), 6 (new), 0 (No change)

Resources: 5745 (old), 5745 (new), 0 (No change)

Anim: 33 (old), 33 (new), 0 (No change)
Animator: 24 (old), 24 (new), 0 (No change)
Array: 14 (old), 14 (new), 0 (No change)
Attr: 888 (old), 888 (new), 0 (No change)
Bool: 8 (old), 8 (new), 0 (No change)
Color: 806 (old), 806 (new), 0 (No change)
Dimen: 765 (old), 765 (new), 0 (No change)
Drawable: 340 (old), 340 (new), 0 (No change)
Id: 1217 (old), 1217 (new), 0 (No change)
Integer: 32 (old), 32 (new), 0 (No change)
Interpolator: 11 (old), 11 (new), 0 (No change)
Layout: 341 (old), 341 (new), 0 (No change)
Menu: 1 (old), 1 (new), 0 (No change)
Mipmap: 1 (old), 1 (new), 0 (No change)
Plurals: 10 (old), 10 (new), 0 (No change)
String: 781 (old), 781 (new), 0 (No change)
Style: 472 (old), 472 (new), 0 (No change)
Xml: 1 (old), 1 (new), 0 (No change)

Lesson assets: 111 (old), 111 (new), 0 (No change)

AAB differences

Expand to see AAB specifics

Supported configurations:

hdpi (same)
ldpi (same)
mdpi (same)
tvdpi (same)
xhdpi (same)
xxhdpi (same)
xxxhdpi (same)

Base APK

APK file size: 10 MiB (old), 10 MiB (new), 60 bytes (Removed)
APK download size (estimated): 9 MiB (old), 9 MiB (new), 96 bytes (Added)
Method count: 114850 (old), 114851 (new), 1 (Added)

Configuration hdpi

APK file size: 43 KiB (old), 43 KiB (new), 0 bytes (No change)
APK download size (estimated): 17 KiB (old), 17 KiB (new), 0 bytes (No change)

Configuration ldpi

APK file size: 44 KiB (old), 44 KiB (new), 0 bytes (No change)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 0 bytes (No change)

Configuration mdpi

APK file size: 38 KiB (old), 38 KiB (new), 0 bytes (No change)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 0 bytes (No change)

Configuration tvdpi

APK file size: 72 KiB (old), 72 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)

Configuration xhdpi

APK file size: 49 KiB (old), 49 KiB (new), 0 bytes (No change)
APK download size (estimated): 20 KiB (old), 20 KiB (new), 0 bytes (No change)

Configuration xxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change)
APK download size (estimated): 28 KiB (old), 28 KiB (new), 0 bytes (No change)

Configuration xxxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)

subhajitxyz · 2024-07-14T20:30:36Z

Now i have signed CLA.

Vishwajith-Shettigar · 2024-07-15T06:47:48Z

Hi @subhajitxyz, thanks for creating a PR. Could you please update your PR according to the essential checklist?

subhajitxyz · 2024-07-15T08:29:17Z

Thank you. I am updating.

…

On Mon, 15 Jul 2024, 12:18 pm Vishwajith Shettigar, < ***@***.***> wrote: Assigned #5463 <#5463> to @subhajitxyz <https://github.com/subhajitxyz>. — Reply to this email directly, view it on GitHub <#5463 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/BEUAZ2W3S6TSMFG3OOTI243ZMNWEVAVCNFSM6AAAAABK2EKPJSVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJTGUYDAOBYGIZDINQ> . You are receiving this because you were assigned.Message ID: ***@***.***>

subhajitxyz

Checked.

Vishwajith-Shettigar · 2024-07-15T09:07:07Z

@subhajitxyz update title also. Take #5382 for reference.

subhajitxyz · 2024-07-15T12:03:17Z

@subhajitxyz update title also. Take #5382 for reference.

I have updated the title as per your reference . Please review and let me know if there are any additional adjustments needed.

Vishwajith-Shettigar · 2024-07-15T12:16:06Z

@subhajitxyz replace Fixes with Fix in title, and assign @adhiamboperes.

subhajitxyz · 2024-07-15T12:25:40Z

@subhajitxyz replace Fixes with Fix in title, and assign @adhiamboperes.

I have updated the title by replacing Fixes with Fix and assigned the issue to @adhiamboperes. Please check and let me know if everything looks good now.

github-actions · 2024-07-16T03:57:56Z

APK & AAB differences analysis

Note that this is a summarized snapshot. See the CI artifacts for detailed differences.

Dev

Expand to see flavor specifics

Universal APK

APK file size: 19 MiB (old), 19 MiB (new), 344 bytes (Removed)

APK download size (estimated): 17 MiB (old), 17 MiB (new), 99 bytes (Added)

Method count: 258445 (old), 258446 (new), 1 (Added)

Features: 2 (old), 2 (new), 0 (No change)

Permissions: 6 (old), 6 (new), 0 (No change)

Resources: 6775 (old), 6775 (new), 0 (No change)

Anim: 43 (old), 43 (new), 0 (No change)
Animator: 26 (old), 26 (new), 0 (No change)
Array: 15 (old), 15 (new), 0 (No change)
Attr: 922 (old), 922 (new), 0 (No change)
Bool: 9 (old), 9 (new), 0 (No change)
Color: 954 (old), 954 (new), 0 (No change)
Dimen: 1030 (old), 1030 (new), 0 (No change)
Drawable: 378 (old), 378 (new), 0 (No change)
Id: 1271 (old), 1271 (new), 0 (No change)
Integer: 37 (old), 37 (new), 0 (No change)
Interpolator: 11 (old), 11 (new), 0 (No change)
Layout: 378 (old), 378 (new), 0 (No change)
Menu: 3 (old), 3 (new), 0 (No change)
Mipmap: 1 (old), 1 (new), 0 (No change)
Plurals: 10 (old), 10 (new), 0 (No change)
Raw: 2 (old), 2 (new), 0 (No change)
String: 848 (old), 848 (new), 0 (No change)
Style: 831 (old), 831 (new), 0 (No change)
Xml: 6 (old), 6 (new), 0 (No change)

Lesson assets: 111 (old), 111 (new), 0 (No change)

AAB differences

Expand to see AAB specifics

Supported configurations:

hdpi (same)
ldpi (same)
mdpi (same)
tvdpi (same)
xhdpi (same)
xxhdpi (same)
xxxhdpi (same)

Base APK

APK file size: 18 MiB (old), 18 MiB (new), 348 bytes (Removed)
APK download size (estimated): 17 MiB (old), 17 MiB (new), 142 bytes (Added)
Method count: 258445 (old), 258446 (new), 1 (Added)

Configuration hdpi

APK file size: 49 KiB (old), 49 KiB (new), 0 bytes (No change)
APK download size (estimated): 18 KiB (old), 18 KiB (new), 0 bytes (No change)

Configuration ldpi

APK file size: 48 KiB (old), 48 KiB (new), 0 bytes (No change)
APK download size (estimated): 14 KiB (old), 14 KiB (new), 0 bytes (No change)

Configuration mdpi

APK file size: 45 KiB (old), 45 KiB (new), 0 bytes (No change)
APK download size (estimated): 14 KiB (old), 14 KiB (new), 0 bytes (No change)

Configuration tvdpi

APK file size: 85 KiB (old), 85 KiB (new), 0 bytes (No change)
APK download size (estimated): 29 KiB (old), 29 KiB (new), 0 bytes (No change)

Configuration xhdpi

APK file size: 56 KiB (old), 56 KiB (new), 0 bytes (No change)
APK download size (estimated): 21 KiB (old), 21 KiB (new), 0 bytes (No change)

Configuration xxhdpi

APK file size: 62 KiB (old), 62 KiB (new), 0 bytes (No change)
APK download size (estimated): 29 KiB (old), 29 KiB (new), 0 bytes (No change)

Configuration xxxhdpi

APK file size: 63 KiB (old), 63 KiB (new), 0 bytes (No change)
APK download size (estimated): 28 KiB (old), 28 KiB (new), 0 bytes (No change)

Alpha

Expand to see flavor specifics

Universal APK

APK file size: 11 MiB (old), 11 MiB (new), 88 bytes (Removed)

APK download size (estimated): 10 MiB (old), 10 MiB (new), 137 bytes (Removed)

Method count: 114844 (old), 114845 (new), 1 (Added)

Features: 2 (old), 2 (new), 0 (No change)

Permissions: 6 (old), 6 (new), 0 (No change)

Resources: 5745 (old), 5745 (new), 0 (No change)

Anim: 33 (old), 33 (new), 0 (No change)
Animator: 24 (old), 24 (new), 0 (No change)
Array: 14 (old), 14 (new), 0 (No change)
Attr: 888 (old), 888 (new), 0 (No change)
Bool: 8 (old), 8 (new), 0 (No change)
Color: 806 (old), 806 (new), 0 (No change)
Dimen: 765 (old), 765 (new), 0 (No change)
Drawable: 340 (old), 340 (new), 0 (No change)
Id: 1217 (old), 1217 (new), 0 (No change)
Integer: 32 (old), 32 (new), 0 (No change)
Interpolator: 11 (old), 11 (new), 0 (No change)
Layout: 341 (old), 341 (new), 0 (No change)
Menu: 1 (old), 1 (new), 0 (No change)
Mipmap: 1 (old), 1 (new), 0 (No change)
Plurals: 10 (old), 10 (new), 0 (No change)
String: 781 (old), 781 (new), 0 (No change)
Style: 472 (old), 472 (new), 0 (No change)
Xml: 1 (old), 1 (new), 0 (No change)

Lesson assets: 111 (old), 111 (new), 0 (No change)

AAB differences

Expand to see AAB specifics

Supported configurations:

hdpi (same)
ldpi (same)
mdpi (same)
tvdpi (same)
xhdpi (same)
xxhdpi (same)
xxxhdpi (same)

Base APK

APK file size: 10 MiB (old), 10 MiB (new), 88 bytes (Removed)
APK download size (estimated): 9 MiB (old), 9 MiB (new), 102 bytes (Removed)
Method count: 114844 (old), 114845 (new), 1 (Added)

Configuration hdpi

APK file size: 43 KiB (old), 43 KiB (new), 0 bytes (No change)
APK download size (estimated): 17 KiB (old), 17 KiB (new), 0 bytes (No change)

Configuration ldpi

APK file size: 44 KiB (old), 44 KiB (new), 0 bytes (No change)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 0 bytes (No change)

Configuration mdpi

APK file size: 38 KiB (old), 38 KiB (new), 0 bytes (No change)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 0 bytes (No change)

Configuration tvdpi

APK file size: 72 KiB (old), 72 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)

Configuration xhdpi

APK file size: 49 KiB (old), 49 KiB (new), 0 bytes (No change)
APK download size (estimated): 20 KiB (old), 20 KiB (new), 0 bytes (No change)

Configuration xxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change)
APK download size (estimated): 28 KiB (old), 28 KiB (new), 0 bytes (No change)

Configuration xxxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)

Beta

Expand to see flavor specifics

Universal APK

APK file size: 11 MiB (old), 11 MiB (new), 100 bytes (Removed)

APK download size (estimated): 10 MiB (old), 10 MiB (new), 724 bytes (Added)

Method count: 114850 (old), 114851 (new), 1 (Added)

Features: 2 (old), 2 (new), 0 (No change)

Permissions: 6 (old), 6 (new), 0 (No change)

Resources: 5745 (old), 5745 (new), 0 (No change)

Anim: 33 (old), 33 (new), 0 (No change)
Animator: 24 (old), 24 (new), 0 (No change)
Array: 14 (old), 14 (new), 0 (No change)
Attr: 888 (old), 888 (new), 0 (No change)
Bool: 8 (old), 8 (new), 0 (No change)
Color: 806 (old), 806 (new), 0 (No change)
Dimen: 765 (old), 765 (new), 0 (No change)
Drawable: 340 (old), 340 (new), 0 (No change)
Id: 1217 (old), 1217 (new), 0 (No change)
Integer: 32 (old), 32 (new), 0 (No change)
Interpolator: 11 (old), 11 (new), 0 (No change)
Layout: 341 (old), 341 (new), 0 (No change)
Menu: 1 (old), 1 (new), 0 (No change)
Mipmap: 1 (old), 1 (new), 0 (No change)
Plurals: 10 (old), 10 (new), 0 (No change)
String: 781 (old), 781 (new), 0 (No change)
Style: 472 (old), 472 (new), 0 (No change)
Xml: 1 (old), 1 (new), 0 (No change)

Lesson assets: 111 (old), 111 (new), 0 (No change)

AAB differences

Expand to see AAB specifics

Supported configurations:

hdpi (same)
ldpi (same)
mdpi (same)
tvdpi (same)
xhdpi (same)
xxhdpi (same)
xxxhdpi (same)

Base APK

APK file size: 10 MiB (old), 10 MiB (new), 96 bytes (Removed)
APK download size (estimated): 9 MiB (old), 9 MiB (new), 21 bytes (Added)
Method count: 114850 (old), 114851 (new), 1 (Added)

Configuration hdpi

APK file size: 43 KiB (old), 43 KiB (new), 0 bytes (No change)
APK download size (estimated): 17 KiB (old), 17 KiB (new), 0 bytes (No change)

Configuration ldpi

APK file size: 44 KiB (old), 44 KiB (new), 0 bytes (No change)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 0 bytes (No change)

Configuration mdpi

APK file size: 38 KiB (old), 38 KiB (new), 0 bytes (No change)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 0 bytes (No change)

Configuration tvdpi

APK file size: 72 KiB (old), 72 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)

Configuration xhdpi

APK file size: 49 KiB (old), 49 KiB (new), 0 bytes (No change)
APK download size (estimated): 20 KiB (old), 20 KiB (new), 0 bytes (No change)

Configuration xxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change)
APK download size (estimated): 28 KiB (old), 28 KiB (new), 0 bytes (No change)

Configuration xxxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)

Ga

Expand to see flavor specifics

Universal APK

APK file size: 11 MiB (old), 11 MiB (new), 56 bytes (Removed)

APK download size (estimated): 10 MiB (old), 10 MiB (new), 835 bytes (Added)

Method count: 114850 (old), 114851 (new), 1 (Added)

Features: 2 (old), 2 (new), 0 (No change)

Permissions: 6 (old), 6 (new), 0 (No change)

Resources: 5745 (old), 5745 (new), 0 (No change)

Anim: 33 (old), 33 (new), 0 (No change)
Animator: 24 (old), 24 (new), 0 (No change)
Array: 14 (old), 14 (new), 0 (No change)
Attr: 888 (old), 888 (new), 0 (No change)
Bool: 8 (old), 8 (new), 0 (No change)
Color: 806 (old), 806 (new), 0 (No change)
Dimen: 765 (old), 765 (new), 0 (No change)
Drawable: 340 (old), 340 (new), 0 (No change)
Id: 1217 (old), 1217 (new), 0 (No change)
Integer: 32 (old), 32 (new), 0 (No change)
Interpolator: 11 (old), 11 (new), 0 (No change)
Layout: 341 (old), 341 (new), 0 (No change)
Menu: 1 (old), 1 (new), 0 (No change)
Mipmap: 1 (old), 1 (new), 0 (No change)
Plurals: 10 (old), 10 (new), 0 (No change)
String: 781 (old), 781 (new), 0 (No change)
Style: 472 (old), 472 (new), 0 (No change)
Xml: 1 (old), 1 (new), 0 (No change)

Lesson assets: 111 (old), 111 (new), 0 (No change)

AAB differences

Expand to see AAB specifics

Supported configurations:

hdpi (same)
ldpi (same)
mdpi (same)
tvdpi (same)
xhdpi (same)
xxhdpi (same)
xxxhdpi (same)

Base APK

APK file size: 10 MiB (old), 10 MiB (new), 60 bytes (Removed)
APK download size (estimated): 9 MiB (old), 9 MiB (new), 114 bytes (Added)
Method count: 114850 (old), 114851 (new), 1 (Added)

Configuration hdpi

APK file size: 43 KiB (old), 43 KiB (new), 0 bytes (No change)
APK download size (estimated): 17 KiB (old), 17 KiB (new), 0 bytes (No change)

Configuration ldpi

APK file size: 44 KiB (old), 44 KiB (new), 0 bytes (No change)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 0 bytes (No change)

Configuration mdpi

APK file size: 38 KiB (old), 38 KiB (new), 0 bytes (No change)
APK download size (estimated): 13 KiB (old), 13 KiB (new), 0 bytes (No change)

Configuration tvdpi

APK file size: 72 KiB (old), 72 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)

Configuration xhdpi

APK file size: 49 KiB (old), 49 KiB (new), 0 bytes (No change)
APK download size (estimated): 20 KiB (old), 20 KiB (new), 0 bytes (No change)

Configuration xxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change)
APK download size (estimated): 28 KiB (old), 28 KiB (new), 0 bytes (No change)

Configuration xxxhdpi

APK file size: 55 KiB (old), 55 KiB (new), 0 bytes (No change)
APK download size (estimated): 27 KiB (old), 27 KiB (new), 0 bytes (No change)

adhiamboperes · 2024-07-16T09:12:26Z

@theMr17, PTAL.

theMr17

Thanks @subhajitxyz! Had one minor comment, PTAL.

app/src/main/java/org/oppia/android/app/player/state/StateFragmentPresenter.kt

…mentPresenter.kt Co-authored-by: Mr. 17 <saptakmanna100@gmail.com>

theMr17

Thanks @subhajitxyz, this LGTM!

oppiabot · 2024-07-16T14:03:54Z

Assigning @adhiamboperes for code owner reviews. Thanks!

adhiamboperes

LGTM, thanks @subhajitxyz!

Thanks @Vishwajith-Shettigar and @theMr17 as well!

oppiabot · 2024-07-16T22:35:57Z

Unassigning @adhiamboperes since they have already approved the PR.

oppiabot · 2024-07-16T22:36:01Z

Hi @subhajitxyz, this PR is ready to be merged. Please address any remaining comments prior to merging, and feel free to ask someone to merge your PR once the CI checks pass and you're happy with it. Thanks!

subhajitxyz · 2024-07-17T03:31:52Z

Thank you all for guiding me through my first contribution.

update deprecated InputMethodManager.SHOW_FORCED usage

65c9932

subhajitxyz requested a review from a team as a code owner July 13, 2024 09:50

subhajitxyz requested a review from adhiamboperes July 13, 2024 09:50

Merge branch 'develop' into fix/keyboard-hide-deprecation

9cc6cf0

Vishwajith-Shettigar assigned subhajitxyz Jul 15, 2024

subhajitxyz commented Jul 15, 2024

View reviewed changes

subhajitxyz changed the title ~~update deprecated InputMethodManager.SHOW_FORCED usage~~ Fixes #5406: Migrate keyboard hiding functionality Jul 15, 2024

subhajitxyz changed the title ~~Fixes #5406: Migrate keyboard hiding functionality~~ Fix #5406: Migrate keyboard hiding functionality Jul 15, 2024

Vishwajith-Shettigar assigned adhiamboperes and unassigned subhajitxyz Jul 15, 2024

adhiamboperes assigned theMr17 and unassigned adhiamboperes Jul 16, 2024

theMr17 requested changes Jul 16, 2024

View reviewed changes

app/src/main/java/org/oppia/android/app/player/state/StateFragmentPresenter.kt Outdated Show resolved Hide resolved

theMr17 assigned subhajitxyz and unassigned theMr17 Jul 16, 2024

subhajitxyz and others added 3 commits July 16, 2024 17:26

Update SurveyFragmentPresenter.kt

480d28c

Update app/src/main/java/org/oppia/android/app/player/state/StateFrag…

9fd1db7

…mentPresenter.kt Co-authored-by: Mr. 17 <saptakmanna100@gmail.com>

Update QuestionPlayerFragmentPresenter.kt

f9b3c2d

theMr17 approved these changes Jul 16, 2024

View reviewed changes

oppiabot bot assigned adhiamboperes Jul 16, 2024

adhiamboperes approved these changes Jul 16, 2024

View reviewed changes

Merge branch 'develop' into fix/keyboard-hide-deprecation

92fc4c1

adhiamboperes enabled auto-merge (squash) July 16, 2024 22:33

oppiabot bot unassigned adhiamboperes Jul 16, 2024

oppiabot bot added the PR: LGTM label Jul 16, 2024

adhiamboperes merged commit 436cf9e into oppia:develop Jul 16, 2024
37 checks passed

Rd4dev mentioned this pull request Jul 19, 2024

[Feature Request]: Migrate keyboard hiding functionality #5406

Closed

3 tasks

Fix #5406: Migrate keyboard hiding functionality #5463

Fix #5406: Migrate keyboard hiding functionality #5463

Conversation

subhajitxyz commented Jul 13, 2024 • edited Loading

Explanation

Essential Checklist

github-actions bot commented Jul 13, 2024

github-actions bot commented Jul 14, 2024

APK & AAB differences analysis

Dev

Universal APK

AAB differences

Base APK

Configuration hdpi

Configuration ldpi

Configuration mdpi

Configuration tvdpi

Configuration xhdpi

Configuration xxhdpi

Configuration xxxhdpi

Alpha

Universal APK

AAB differences

Base APK

Configuration hdpi

Configuration ldpi

Configuration mdpi

Configuration tvdpi

Configuration xhdpi

Configuration xxhdpi

Configuration xxxhdpi

Beta

Universal APK

AAB differences

Base APK

Configuration hdpi

Configuration ldpi

Configuration mdpi

Configuration tvdpi

Configuration xhdpi

Configuration xxhdpi

Configuration xxxhdpi

Ga

Universal APK

AAB differences

Base APK

Configuration hdpi

Configuration ldpi

Configuration mdpi

Configuration tvdpi

Configuration xhdpi

Configuration xxhdpi

Configuration xxxhdpi

subhajitxyz commented Jul 14, 2024

Vishwajith-Shettigar commented Jul 15, 2024

subhajitxyz commented Jul 15, 2024 via email

subhajitxyz left a comment

Choose a reason for hiding this comment

Vishwajith-Shettigar commented Jul 15, 2024 • edited Loading

subhajitxyz commented Jul 15, 2024

Vishwajith-Shettigar commented Jul 15, 2024

subhajitxyz commented Jul 15, 2024

github-actions bot commented Jul 16, 2024

APK & AAB differences analysis

Dev

Universal APK

AAB differences

Base APK

Configuration hdpi

Configuration ldpi

Configuration mdpi

Configuration tvdpi

Configuration xhdpi

Configuration xxhdpi

Configuration xxxhdpi

Alpha

Universal APK

AAB differences

Base APK

Configuration hdpi

subhajitxyz commented Jul 13, 2024 •

edited

Loading

Vishwajith-Shettigar commented Jul 15, 2024 •

edited

Loading