-
Notifications
You must be signed in to change notification settings - Fork 517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix : #4793 #5092
Fix : #4793 #5092
Conversation
@adhiamboperes PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @prafulbbandre!
I have left some comments inline. Please also update the PR title with issue title.
Unassigning @adhiamboperes since the review is done. |
Hi @prafulbbandre, it looks like some changes were requested on this pull request by @adhiamboperes. PTAL. Thanks! |
Hi @adhiamboperes PTAL |
Unassigning @prafulbbandre since a re-review was requested. @prafulbbandre, please make sure you have addressed all review comments. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @prafulbbandre, thank you, I have reviewed your changes and left a comment in-line.
Please also:
- Review the wiki section on submitting a PR. Let the reviewer resolve the comment threads themselves, unless otherwise specified.
- Please update the video in the description once you confirm your latest changes.
Unassigning @adhiamboperes since the review is done. |
Hi @prafulbbandre, it looks like some changes were requested on this pull request by @adhiamboperes. PTAL. Thanks! |
Thanks @prafulbbandre. |
Explanation
Fixes #4793
Note: The exploration player page close button was also saying navigate up so i changed it to close.
Essential Checklist
For UI-specific PRs only
Screenrecorder-2023-07-17-23-27-35-819.mp4
If your PR includes UI-related changes, then: