Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix : #4793 #5092

Merged
merged 13 commits into from
Jul 20, 2023
Merged

Fix : #4793 #5092

merged 13 commits into from
Jul 20, 2023

Conversation

prafulbbandre
Copy link
Contributor

Explanation

Fixes #4793

Note: The exploration player page close button was also saying navigate up so i changed it to close.

Essential Checklist

  • The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • Any changes to scripts/assets files have their rationale included in the PR explanation.
  • The PR follows the style guide.
  • The PR does not contain any unnecessary code changes from Android Studio (reference).
  • The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
  • The PR is assigned to the appropriate reviewers (reference).

For UI-specific PRs only

Screenrecorder-2023-07-17-23-27-35-819.mp4

If your PR includes UI-related changes, then:

  • Add screenshots for portrait/landscape for both a tablet & phone of the before & after UI changes
  • For the screenshots above, include both English and pseudo-localized (RTL) screenshots (see RTL guide)
  • Add a video showing the full UX flow with a screen reader enabled (see accessibility guide)
  • Add a screenshot demonstrating that you ran affected Espresso tests locally & that they're passing

@prafulbbandre prafulbbandre requested a review from a team as a code owner July 17, 2023 18:05
@prafulbbandre
Copy link
Contributor Author

@adhiamboperes PTAL
Thanks a lot for help.

Copy link
Collaborator

@adhiamboperes adhiamboperes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @prafulbbandre!

I have left some comments inline. Please also update the PR title with issue title.

app/src/main/res/layout/resume_lesson_activity.xml Outdated Show resolved Hide resolved
app/src/main/res/layout/exploration_activity.xml Outdated Show resolved Hide resolved
@oppiabot
Copy link

oppiabot bot commented Jul 18, 2023

Unassigning @adhiamboperes since the review is done.

@oppiabot
Copy link

oppiabot bot commented Jul 18, 2023

Hi @prafulbbandre, it looks like some changes were requested on this pull request by @adhiamboperes. PTAL. Thanks!

@prafulbbandre
Copy link
Contributor Author

Hi @adhiamboperes PTAL

@oppiabot
Copy link

oppiabot bot commented Jul 19, 2023

Unassigning @prafulbbandre since a re-review was requested. @prafulbbandre, please make sure you have addressed all review comments. Thanks!

Copy link
Collaborator

@adhiamboperes adhiamboperes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @prafulbbandre, thank you, I have reviewed your changes and left a comment in-line.

Please also:

  1. Review the wiki section on submitting a PR. Let the reviewer resolve the comment threads themselves, unless otherwise specified.
  2. Please update the video in the description once you confirm your latest changes.

app/src/main/res/layout/resume_lesson_activity.xml Outdated Show resolved Hide resolved
@oppiabot
Copy link

oppiabot bot commented Jul 19, 2023

Unassigning @adhiamboperes since the review is done.

@oppiabot
Copy link

oppiabot bot commented Jul 19, 2023

Hi @prafulbbandre, it looks like some changes were requested on this pull request by @adhiamboperes. PTAL. Thanks!

@adhiamboperes
Copy link
Collaborator

Thanks @prafulbbandre.

@adhiamboperes adhiamboperes merged commit a2fdc7a into oppia:develop Jul 20, 2023
36 checks passed
@prafulbbandre prafulbbandre deleted the talkback branch July 20, 2023 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Talkback is reading close icon as navigator button in Hints page
2 participants