Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #3841: 'time_ago' & quantity plurals should be combined #4558

Closed
wants to merge 1 commit into from

Conversation

mbobiosio
Copy link

Explanation

Fixes #3841
Fixes #3842
This PR includes the required update to combine strings together

Essential Checklist

  • The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • Any changes to scripts/assets files have their rationale included in the PR explanation.
  • The PR follows the style guide.
  • The PR does not contain any unnecessary code changes from Android Studio (reference).
  • The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
  • The PR is assigned to the appropriate reviewers (reference).

For UI-specific PRs only

If your PR includes UI-related changes, then:

  • Add screenshots for portrait/landscape for both a tablet & phone of the before & after UI changes
  • For the screenshots above, include both English and pseudo-localized (RTL) screenshots (see RTL guide)
  • Add a video showing the full UX flow with a screen reader enabled (see accessibility guide)
  • Add a screenshot demonstrating that you ran affected Espresso tests locally & that they're passing

Copy link
Sponsor Member

@BenHenning BenHenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mbobiosio. I'm a bit confused since this PR seems incomplete as changes that were previously here are no longer here.

Also, as mentioned in #4560 please include relevant screenshots in the PR description to demonstrate the visual changes introduced as part of this PR.

resourceHandler.getQuantityStringInLocaleWithWrapping(
pluralsResId, count, String.valueOf(count)
)
return resourceHandler.getQuantityStringInLocaleWithWrapping(
Copy link
Sponsor Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this change going to remove the time_ago text altogether? I'm not sure that's what we want without the code that combines plurals. Is there a reason that was removed in this new PR?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I figured yesterday there's this problem from CI tests. I'll work to resolve this.

@BenHenning BenHenning assigned mbobiosio and unassigned BenHenning Sep 7, 2022
@rt4914 rt4914 removed their assignment Sep 7, 2022
@oppiabot
Copy link

oppiabot bot commented Sep 14, 2022

Hi @mbobiosio, I'm going to mark this PR as stale because it hasn't had any updates for 7 days. If no further activity occurs within 7 days, it will be automatically closed so that others can take up the issue.
If you are still working on this PR, please make a follow-up commit within 3 days (and submit it for review, if applicable). Please also let us know if you are stuck so we can help you!

@oppiabot oppiabot bot added the stale Corresponds to items that haven't seen a recent update and may be automatically closed. label Sep 14, 2022
@oppiabot oppiabot bot closed this Sep 21, 2022
@BenHenning
Copy link
Sponsor Member

@mbobiosio are you working on this still?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale Corresponds to items that haven't seen a recent update and may be automatically closed.
Projects
None yet
3 participants