Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes part of #1433: Including Console Logger into Oppia Logger #3104

Merged
merged 7 commits into from
May 13, 2021
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -16,18 +16,18 @@ import org.oppia.android.app.fragment.FragmentScope
import org.oppia.android.app.model.DeviceSettings
import org.oppia.android.app.model.ProfileId
import org.oppia.android.app.shim.IntentFactoryShim
import org.oppia.android.domain.oppialogger.OppiaLogger
import org.oppia.android.domain.profile.ProfileManagementController
import org.oppia.android.util.data.AsyncResult
import org.oppia.android.util.data.DataProviders.Companion.toLiveData
import org.oppia.android.util.logging.ConsoleLogger
import javax.inject.Inject

/** [ViewModel] for [AdministratorControlsFragment]. */
@FragmentScope
class AdministratorControlsViewModel @Inject constructor(
private val activity: AppCompatActivity,
private val fragment: Fragment,
private val logger: ConsoleLogger,
private val oppiaLogger: OppiaLogger,
private val profileManagementController: ProfileManagementController,
private val IntentFactoryShim: IntentFactoryShim
) {
Expand All @@ -51,7 +51,7 @@ class AdministratorControlsViewModel @Inject constructor(
deviceSettingsResult: AsyncResult<DeviceSettings>
): DeviceSettings {
if (deviceSettingsResult.isFailure()) {
logger.e(
oppiaLogger.e(
"AdministratorControlsFragment",
"Failed to retrieve profile",
deviceSettingsResult.getErrorOrNull()!!
Expand All @@ -75,7 +75,7 @@ class AdministratorControlsViewModel @Inject constructor(
itemViewModelList.add(
AdministratorControlsDownloadPermissionsViewModel(
fragment,
logger,
oppiaLogger,
profileManagementController,
userProfileId,
deviceSettings
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,14 +5,14 @@ import androidx.fragment.app.Fragment
import androidx.lifecycle.Observer
import org.oppia.android.app.model.DeviceSettings
import org.oppia.android.app.model.ProfileId
import org.oppia.android.domain.oppialogger.OppiaLogger
import org.oppia.android.domain.profile.ProfileManagementController
import org.oppia.android.util.data.DataProviders.Companion.toLiveData
import org.oppia.android.util.logging.ConsoleLogger

/** [ViewModel] for the recycler view in [AdministratorControlsFragment]. */
class AdministratorControlsDownloadPermissionsViewModel(
private val fragment: Fragment,
private val logger: ConsoleLogger,
private val oppiaLogger: OppiaLogger,
private val profileManagementController: ProfileManagementController,
private val userProfileId: ProfileId,
deviceSettings: DeviceSettings
Expand All @@ -30,7 +30,7 @@ class AdministratorControlsDownloadPermissionsViewModel(
fragment,
Observer {
if (it.isFailure()) {
logger.e(
oppiaLogger.e(
"AdministratorControlsFragment",
"Failed to update topic update on wifi permission",
it.getErrorOrNull()!!
Expand All @@ -48,7 +48,7 @@ class AdministratorControlsDownloadPermissionsViewModel(
fragment,
Observer {
if (it.isFailure()) {
logger.e(
oppiaLogger.e(
"AdministratorControlsFragment",
"Failed to update topic auto update permission",
it.getErrorOrNull()!!
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,10 @@ import org.oppia.android.app.model.CompletedStoryList
import org.oppia.android.app.model.ProfileId
import org.oppia.android.app.shim.IntentFactoryShim
import org.oppia.android.app.viewmodel.ObservableViewModel
import org.oppia.android.domain.oppialogger.OppiaLogger
import org.oppia.android.domain.topic.TopicController
import org.oppia.android.util.data.AsyncResult
import org.oppia.android.util.data.DataProviders.Companion.toLiveData
import org.oppia.android.util.logging.ConsoleLogger
import org.oppia.android.util.parser.StoryHtmlParserEntityType
import javax.inject.Inject

Expand All @@ -21,7 +21,7 @@ class CompletedStoryListViewModel @Inject constructor(
private val activity: AppCompatActivity,
private val intentFactoryShim: IntentFactoryShim,
private val topicController: TopicController,
private val logger: ConsoleLogger,
private val oppiaLogger: OppiaLogger,
@StoryHtmlParserEntityType private val entityType: String
) : ObservableViewModel() {
/** [internalProfileId] needs to be set before any of the live data members can be accessed. */
Expand Down Expand Up @@ -49,7 +49,7 @@ class CompletedStoryListViewModel @Inject constructor(
completedStoryListResult: AsyncResult<CompletedStoryList>
): CompletedStoryList {
if (completedStoryListResult.isFailure()) {
logger.e(
oppiaLogger.e(
"CompletedStoryListFragment",
"Failed to retrieve CompletedStory list: ",
completedStoryListResult.getErrorOrNull()!!
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,8 @@ import org.oppia.android.R
import org.oppia.android.app.model.LessonThumbnail
import org.oppia.android.app.model.LessonThumbnailGraphic
import org.oppia.android.app.shim.ViewComponentFactory
import org.oppia.android.domain.oppialogger.OppiaLogger
import org.oppia.android.util.gcsresource.DefaultResourceBucketName
import org.oppia.android.util.logging.ConsoleLogger
import org.oppia.android.util.parser.DefaultGcsPrefix
import org.oppia.android.util.parser.ImageLoader
import org.oppia.android.util.parser.ImageTransformation
Expand Down Expand Up @@ -48,7 +48,7 @@ class LessonThumbnailImageView @JvmOverloads constructor(
lateinit var gcsPrefix: String

@Inject
lateinit var logger: ConsoleLogger
lateinit var oppiaLogger: OppiaLogger

fun setEntityId(entityId: String) {
this.entityId = entityId
Expand Down Expand Up @@ -77,7 +77,7 @@ class LessonThumbnailImageView @JvmOverloads constructor(
::resourceBucketName.isInitialized &&
::gcsPrefix.isInitialized &&
::imageLoader.isInitialized &&
::logger.isInitialized
::oppiaLogger.isInitialized
) {
loadLessonThumbnail()
}
Expand Down Expand Up @@ -123,8 +123,8 @@ class LessonThumbnailImageView @JvmOverloads constructor(
(FragmentManager.findFragment<Fragment>(this) as ViewComponentFactory)
.createViewComponent(this).inject(this)
} catch (e: IllegalStateException) {
if (::logger.isInitialized)
logger.e(
if (::oppiaLogger.isInitialized)
oppiaLogger.e(
"LessonThumbnailImageView",
"Throws exception on attach to window",
e
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -32,11 +32,11 @@ import org.oppia.android.app.topic.TopicActivity
import org.oppia.android.app.viewmodel.ViewModelProvider
import org.oppia.android.databinding.DrawerFragmentBinding
import org.oppia.android.databinding.NavHeaderNavigationDrawerBinding
import org.oppia.android.domain.oppialogger.OppiaLogger
import org.oppia.android.domain.profile.ProfileManagementController
import org.oppia.android.domain.topic.TopicController
import org.oppia.android.util.data.AsyncResult
import org.oppia.android.util.data.DataProviders.Companion.toLiveData
import org.oppia.android.util.logging.ConsoleLogger
import org.oppia.android.util.statusbar.StatusBarColor
import javax.inject.Inject

Expand All @@ -50,7 +50,7 @@ class NavigationDrawerFragmentPresenter @Inject constructor(
private val fragment: Fragment,
private val profileManagementController: ProfileManagementController,
private val topicController: TopicController,
private val logger: ConsoleLogger,
private val oppiaLogger: OppiaLogger,
private val headerViewModelProvider: ViewModelProvider<NavigationDrawerHeaderViewModel>,
private val footerViewModelProvider: ViewModelProvider<NavigationDrawerFooterViewModel>
) : NavigationView.OnNavigationItemSelectedListener {
Expand Down Expand Up @@ -131,7 +131,7 @@ class NavigationDrawerFragmentPresenter @Inject constructor(

private fun processGetProfileResult(profileResult: AsyncResult<Profile>): Profile {
if (profileResult.isFailure()) {
logger.e(
oppiaLogger.e(
"NavigationDrawerFragment",
"Failed to retrieve profile",
profileResult.getErrorOrNull()!!
Expand Down Expand Up @@ -160,7 +160,7 @@ class NavigationDrawerFragmentPresenter @Inject constructor(
completedStoryListResult: AsyncResult<CompletedStoryList>
): CompletedStoryList {
if (completedStoryListResult.isFailure()) {
logger.e(
oppiaLogger.e(
"NavigationDrawerFragment",
"Failed to retrieve completed story list",
completedStoryListResult.getErrorOrNull()!!
Expand Down Expand Up @@ -189,7 +189,7 @@ class NavigationDrawerFragmentPresenter @Inject constructor(
ongoingTopicListResult: AsyncResult<OngoingTopicList>
): OngoingTopicList {
if (ongoingTopicListResult.isFailure()) {
logger.e(
oppiaLogger.e(
"NavigationDrawerFragment",
"Failed to retrieve ongoing topic list",
ongoingTopicListResult.getErrorOrNull()!!
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@ import org.oppia.android.databinding.WelcomeBinding
import org.oppia.android.domain.oppialogger.OppiaLogger
import org.oppia.android.domain.profile.ProfileManagementController
import org.oppia.android.domain.topic.TopicListController
import org.oppia.android.util.logging.ConsoleLogger
import org.oppia.android.util.parser.StoryHtmlParserEntityType
import org.oppia.android.util.parser.TopicHtmlParserEntityType
import org.oppia.android.util.system.OppiaClock
Expand All @@ -39,7 +38,6 @@ class HomeFragmentPresenter @Inject constructor(
private val profileManagementController: ProfileManagementController,
private val topicListController: TopicListController,
private val oppiaClock: OppiaClock,
private val logger: ConsoleLogger,
private val oppiaLogger: OppiaLogger,
@TopicHtmlParserEntityType private val topicEntityType: String,
@StoryHtmlParserEntityType private val storyEntityType: String
Expand All @@ -60,7 +58,7 @@ class HomeFragmentPresenter @Inject constructor(
activity,
fragment,
oppiaClock,
logger,
oppiaLogger,
internalProfileId,
profileManagementController,
topicListController,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,12 +21,12 @@ import org.oppia.android.app.model.PromotedActivityList
import org.oppia.android.app.model.PromotedStoryList
import org.oppia.android.app.model.TopicList
import org.oppia.android.app.viewmodel.ObservableViewModel
import org.oppia.android.domain.oppialogger.OppiaLogger
import org.oppia.android.domain.profile.ProfileManagementController
import org.oppia.android.domain.topic.TopicListController
import org.oppia.android.util.data.DataProvider
import org.oppia.android.util.data.DataProviders.Companion.combineWith
import org.oppia.android.util.data.DataProviders.Companion.toLiveData
import org.oppia.android.util.logging.ConsoleLogger
import org.oppia.android.util.parser.StoryHtmlParserEntityType
import org.oppia.android.util.parser.TopicHtmlParserEntityType
import org.oppia.android.util.system.OppiaClock
Expand All @@ -42,7 +42,7 @@ class HomeViewModel(
private val activity: AppCompatActivity,
private val fragment: Fragment,
private val oppiaClock: OppiaClock,
private val logger: ConsoleLogger,
private val oppiaLogger: OppiaLogger,
private val internalProfileId: Int,
private val profileManagementController: ProfileManagementController,
private val topicListController: TopicListController,
Expand Down Expand Up @@ -95,7 +95,7 @@ class HomeViewModel(
val homeItemViewModelListLiveData: LiveData<List<HomeItemViewModel>> by lazy {
Transformations.map(homeItemViewModelListDataProvider.toLiveData()) { itemListResult ->
if (itemListResult.isFailure()) {
logger.e(
oppiaLogger.e(
"HomeFragment",
"No home fragment available -- failed to retrieve fragment data.",
itemListResult.getErrorOrNull()
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import org.oppia.android.app.recyclerview.BindableAdapter
import org.oppia.android.app.recyclerview.StartSnapHelper
import org.oppia.android.app.shim.ViewBindingShim
import org.oppia.android.app.shim.ViewComponentFactory
import org.oppia.android.util.logging.ConsoleLogger
import org.oppia.android.domain.oppialogger.OppiaLogger
import javax.inject.Inject

private const val COMING_SOON_TOPIC_LIST_VIEW_TAG = "ComingSoonTopicsListView"
Expand All @@ -29,7 +29,7 @@ class ComingSoonTopicsListView @JvmOverloads constructor(
lateinit var bindingInterface: ViewBindingShim

@Inject
lateinit var logger: ConsoleLogger
lateinit var oppiaLogger: OppiaLogger

override fun onAttachedToWindow() {
super.onAttachedToWindow()
Expand Down Expand Up @@ -60,7 +60,7 @@ class ComingSoonTopicsListView @JvmOverloads constructor(
adapter = createAdapter()
}
if (newDataList == null) {
logger.w(COMING_SOON_TOPIC_LIST_VIEW_TAG, "Failed to resolve upcoming topic list data")
oppiaLogger.w(COMING_SOON_TOPIC_LIST_VIEW_TAG, "Failed to resolve upcoming topic list data")
} else {
(adapter as BindableAdapter<*>).setDataUnchecked(newDataList)
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import org.oppia.android.app.recyclerview.BindableAdapter
import org.oppia.android.app.recyclerview.StartSnapHelper
import org.oppia.android.app.shim.ViewBindingShim
import org.oppia.android.app.shim.ViewComponentFactory
import org.oppia.android.util.logging.ConsoleLogger
import org.oppia.android.domain.oppialogger.OppiaLogger
import javax.inject.Inject

private const val PROMOTED_STORY_LIST_VIEW_TAG = "PromotedStoryListView"
Expand All @@ -29,7 +29,7 @@ class PromotedStoryListView @JvmOverloads constructor(
lateinit var bindingInterface: ViewBindingShim

@Inject
lateinit var logger: ConsoleLogger
lateinit var oppiaLogger: OppiaLogger

override fun onAttachedToWindow() {
super.onAttachedToWindow()
Expand Down Expand Up @@ -60,7 +60,7 @@ class PromotedStoryListView @JvmOverloads constructor(
adapter = createAdapter()
}
if (newDataList == null) {
logger.w(PROMOTED_STORY_LIST_VIEW_TAG, "Failed to resolve new story list data")
oppiaLogger.w(PROMOTED_STORY_LIST_VIEW_TAG, "Failed to resolve new story list data")
} else {
(adapter as BindableAdapter<*>).setDataUnchecked(newDataList)
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,10 +18,10 @@ import org.oppia.android.app.model.PromotedActivityList
import org.oppia.android.app.model.PromotedStory
import org.oppia.android.databinding.RecentlyPlayedFragmentBinding
import org.oppia.android.domain.exploration.ExplorationDataController
import org.oppia.android.domain.oppialogger.OppiaLogger
import org.oppia.android.domain.topic.TopicListController
import org.oppia.android.util.data.AsyncResult
import org.oppia.android.util.data.DataProviders.Companion.toLiveData
import org.oppia.android.util.logging.ConsoleLogger
import org.oppia.android.util.parser.StoryHtmlParserEntityType
import javax.inject.Inject

Expand All @@ -30,7 +30,7 @@ import javax.inject.Inject
class RecentlyPlayedFragmentPresenter @Inject constructor(
private val activity: AppCompatActivity,
private val fragment: Fragment,
private val logger: ConsoleLogger,
private val oppiaLogger: OppiaLogger,
private val explorationDataController: ExplorationDataController,
private val topicListController: TopicListController,
@StoryHtmlParserEntityType private val entityType: String
Expand Down Expand Up @@ -223,14 +223,14 @@ class RecentlyPlayedFragmentPresenter @Inject constructor(
fragment,
Observer<AsyncResult<Any?>> { result ->
when {
result.isPending() -> logger.d("RecentlyPlayedFragment", "Loading exploration")
result.isFailure() -> logger.e(
result.isPending() -> oppiaLogger.d("RecentlyPlayedFragment", "Loading exploration")
result.isFailure() -> oppiaLogger.e(
"RecentlyPlayedFragment",
"Failed to load exploration",
result.getErrorOrNull()!!
)
else -> {
logger.d("RecentlyPlayedFragment", "Successfully loaded exploration")
oppiaLogger.d("RecentlyPlayedFragment", "Successfully loaded exploration")
routeToExplorationListener.routeToExploration(
internalProfileId,
topicId,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,10 @@ import org.oppia.android.app.model.OngoingTopicList
import org.oppia.android.app.model.ProfileId
import org.oppia.android.app.shim.IntentFactoryShim
import org.oppia.android.app.viewmodel.ObservableViewModel
import org.oppia.android.domain.oppialogger.OppiaLogger
import org.oppia.android.domain.topic.TopicController
import org.oppia.android.util.data.AsyncResult
import org.oppia.android.util.data.DataProviders.Companion.toLiveData
import org.oppia.android.util.logging.ConsoleLogger
import org.oppia.android.util.parser.TopicHtmlParserEntityType
import javax.inject.Inject

Expand All @@ -20,7 +20,7 @@ import javax.inject.Inject
class OngoingTopicListViewModel @Inject constructor(
private val activity: AppCompatActivity,
private val topicController: TopicController,
private val logger: ConsoleLogger,
private val oppiaLogger: OppiaLogger,
private val intentFactoryShim: IntentFactoryShim,
@TopicHtmlParserEntityType private val entityType: String
) : ObservableViewModel() {
Expand Down Expand Up @@ -49,7 +49,7 @@ class OngoingTopicListViewModel @Inject constructor(
ongoingTopicListResult: AsyncResult<OngoingTopicList>
): OngoingTopicList {
if (ongoingTopicListResult.isFailure()) {
logger.e(
oppiaLogger.e(
"OngoingTopicListFragment",
"Failed to retrieve OngoingTopicList: ",
ongoingTopicListResult.getErrorOrNull()!!
Expand Down
Loading