Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update example screenshots in "Overview of the Oppia Android codebase and architecture" wiki #5017

Closed
MohitGupta121 opened this issue Jun 5, 2023 · 0 comments · Fixed by #5107
Closed

Update example screenshots in "Overview of the Oppia Android codebase and architecture" wiki #5017

MohitGupta121 opened this issue Jun 5, 2023 · 0 comments · Fixed by #5107
Assignees
@MohitGupta121
Labels
bug End user-perceivable behaviors which are not desirable. enhancement End user-perceivable enhancements. Impact: Medium Moderate perceived user impact (non-blocking bugs and general improvements). Work: Low Solution is clear and broken into good-first-issue-sized chunks.

Comments

@MohitGupta121
Copy link
Member

MohitGupta121 commented Jun 5, 2023 •
edited
Loading

Describe the bug
Now in current version of oppia-android we removed "Info" and "Practice" Tabs from app, but the wiki "Overview of the Oppia Android codebase and architecture" is using Info Tab screenshots to gave example of codebase.

Expected behavior
Replace guide and screenshots of "Info Tab" with "Lesson Tab" in this wiki.
@MohitGupta121 MohitGupta121 self-assigned this Jun 5, 2023
@MohitGupta121 MohitGupta121 added Impact: Medium Moderate perceived user impact (non-blocking bugs and general improvements). bug End user-perceivable behaviors which are not desirable. enhancement End user-perceivable enhancements. Work: Low Solution is clear and broken into good-first-issue-sized chunks. labels Jun 8, 2023
@MohitGupta121 MohitGupta121 mentioned this issue Jul 27, 2023
Merged
6 tasks
seanlip pushed a commit that referenced this issue Jul 28, 2023
@MohitGupta121
Fix #5017 : Updated example screenshots in wiki as per new oppia-andr…
faf148b 
…oid ui (#5107)

<!-- READ ME FIRST: Please fill in the explanation section below and
check off every point from the Essential Checklist! -->
## Explanation

Fix #5017 : Updated example screenshots in wiki as per new oppia-android
ui

<!--
- Explain what your PR does. If this PR fixes an existing bug, please
include
- "Fixes #bugnum:" in the explanation so that GitHub can auto-close the
issue
  - when this PR is merged.
  -->

## Essential Checklist
<!-- Please tick the relevant boxes by putting an "x" in them. -->
- [x] The PR title and explanation each start with "Fix #bugnum: " (If
this PR fixes part of an issue, prefix the title with "Fix part of
#bugnum: ...".)
- [ ] Any changes to
[scripts/assets](https://github.com/oppia/oppia-android/tree/develop/scripts/assets)
files have their rationale included in the PR explanation.
- [x] The PR follows the [style
guide](https://github.com/oppia/oppia-android/wiki/Coding-style-guide).
- [x] The PR does not contain any unnecessary code changes from Android
Studio
([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#undo-unnecessary-changes)).
- [x] The PR is made from a branch that's **not** called "develop" and
is up-to-date with "develop".
- [x] The PR is **assigned** to the appropriate reviewers
([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#clarification-regarding-assignees-and-reviewers-section)).

## For UI-specific PRs only
<!-- Delete these section if this PR does not include UI-related
changes. -->
If your PR includes UI-related changes, then:
- Add screenshots for portrait/landscape for both a tablet & phone of
the before & after UI changes
- For the screenshots above, include both English and pseudo-localized
(RTL) screenshots (see [RTL
guide](https://github.com/oppia/oppia-android/wiki/RTL-Guidelines))
- Add a video showing the full UX flow with a screen reader enabled (see
[accessibility
guide](https://github.com/oppia/oppia-android/wiki/Accessibility-A11y-Guide))
- Add a screenshot demonstrating that you ran affected Espresso tests
locally & that they're passing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MohitGupta121 MohitGupta121

Labels
bug End user-perceivable behaviors which are not desirable. enhancement End user-perceivable enhancements. Impact: Medium Moderate perceived user impact (non-blocking bugs and general improvements). Work: Low Solution is clear and broken into good-first-issue-sized chunks.
Projects
[Team] Developer Workflow & Infrastructure - Android
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #5017 : Updated example screenshots in wiki as per new oppia-android ui oppia/oppia-android
1 participant
@MohitGupta121