Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Talkback is reading close icon as navigator button in Hints page #4793

Closed
KolliAnitha opened this issue Dec 19, 2022 · 7 comments · Fixed by #5092
Closed

Talkback is reading close icon as navigator button in Hints page #4793

KolliAnitha opened this issue Dec 19, 2022 · 7 comments · Fixed by #5092
Assignees
Labels
bug End user-perceivable behaviors which are not desirable. good first issue This item is good for new contributors to make their pull request. Impact: Low Low perceived user impact (e.g. edge cases). Work: Low Solution is clear and broken into good-first-issue-sized chunks.

Comments

@KolliAnitha
Copy link

Describe the bug
Talkback is reading close icon as navigator icon in Hints page

To Reproduce
Steps to reproduce the behavior:
Enable Talkback

  1. Go to 'Placevalues' - What are the place values
  2. Click on Continue till you reach the question 'how many place values does your score have, Jaime'
  3. Wait till you get a hint
  4. See error

Expected behavior
Talkback should read close icon instead of navigator button

Demonstration
https://user-images.githubusercontent.com/101634267/208364800-d327449c-e829-4a1d-9d1b-8c99fe0a6134.mp4

Environment
Device/emulator being used: Infinix smart 5A
Android or SDK version (e.g. Android 5 or SDK 21): Android version 12
App version (you can get this through system app settings or via the admin controls menu in-app): 0.10-beta-5e64fae55e

@BenHenning
Copy link
Sponsor Member

Hmm this might be partly out of our control as it largely depends on Talkback preferring to start in the upper left corner, and it may not actually be an issue since that's standard & expected behavior by the screenreader.

That being said, let's keep this open and look into how other, popular apps with known good accessibility support handle these sorts of transitions.

@rt4914
Copy link
Contributor

rt4914 commented Jan 31, 2023

Update: We can actually fix this by changing the content description of close icon. We might need to check other similar screens too like ConceptCard, Revision Card etc which uses close icon and decide whether to read Navigate up or Close

@seanlip seanlip added bug End user-perceivable behaviors which are not desirable. and removed issue_type_bug labels Mar 29, 2023
@adhiamboperes adhiamboperes added good first issue This item is good for new contributors to make their pull request. Impact: Low Low perceived user impact (e.g. edge cases). labels Apr 18, 2023
@adhiamboperes adhiamboperes added the Work: Low Solution is clear and broken into good-first-issue-sized chunks. label May 31, 2023
@prafulbbandre
Copy link
Contributor

Hi @rt4914 @adhiamboperes @MohitGupta121 I would like to work on this.
I will update the strings.xml file by changing Navigate up text to Close Button text.

@adhiamboperes
Copy link
Collaborator

Hi @prafulbbandre, I have assigned the issue to you.

@Abinash6000
Copy link
Contributor

Hi @rt4914 @adhiamboperes @MohitGupta121,
Can I do something here?

@adhiamboperes
Copy link
Collaborator

Hi @Abinash6000, this issue is currently assigned. Please look at one of these that has not yet been assigned.

@Abinash6000
Copy link
Contributor

Ok! Thanks for replying.

@prafulbbandre prafulbbandre mentioned this issue Jul 17, 2023
6 tasks
adhiamboperes pushed a commit that referenced this issue Jul 20, 2023
<!-- READ ME FIRST: Please fill in the explanation section below and
check off every point from the Essential Checklist! -->
## Explanation
Fixes #4793 
<!--
- Explain what your PR does. If this PR fixes an existing bug, please
include
- "Fixes #bugnum:" in the explanation so that GitHub can auto-close the
issue
  - when this PR is merged.
  -->
## Essential Checklist
<!-- Please tick the relevant boxes by putting an "x" in them. -->
- [X] The PR title and explanation each start with "Fix #bugnum: " (If
this PR fixes part of an issue, prefix the title with "Fix part of
#bugnum: ...".)
- [X] Any changes to
[scripts/assets](https://github.com/oppia/oppia-android/tree/develop/scripts/assets)
files have their rationale included in the PR explanation.
- [X] The PR follows the [style
guide](https://github.com/oppia/oppia-android/wiki/Coding-style-guide).
- [X] The PR does not contain any unnecessary code changes from Android
Studio
([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#undo-unnecessary-changes)).
- [X] The PR is made from a branch that's **not** called "develop" and
is up-to-date with "develop".
- [X] The PR is **assigned** to the appropriate reviewers
([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#clarification-regarding-assignees-and-reviewers-section)).

## For UI-specific PRs only


https://github.com/oppia/oppia-android/assets/109658545/e542f6fc-02fc-43de-a413-93fe1e49bc04


<!-- Delete these section if this PR does not include UI-related
changes. -->
If your PR includes UI-related changes, then:
- Add screenshots for portrait/landscape for both a tablet & phone of
the before & after UI changes
- For the screenshots above, include both English and pseudo-localized
(RTL) screenshots (see [RTL
guide](https://github.com/oppia/oppia-android/wiki/RTL-Guidelines))
- Add a video showing the full UX flow with a screen reader enabled (see
[accessibility
guide](https://github.com/oppia/oppia-android/wiki/Accessibility-A11y-Guide))
- Add a screenshot demonstrating that you ran affected Espresso tests
locally & that they're passing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug End user-perceivable behaviors which are not desirable. good first issue This item is good for new contributors to make their pull request. Impact: Low Low perceived user impact (e.g. edge cases). Work: Low Solution is clear and broken into good-first-issue-sized chunks.
7 participants