chat provider vars should just not be nil

operable · Oct 11, 2016 · 18f6a3d · 18f6a3d
1 parent 3223cb9
commit 18f6a3d
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/config/helpers.exs b/config/helpers.exs
@@ -58,7 +58,9 @@ defmodule Cog.Config.Helpers do
   defp enabled_provider?({provider, _module}) do
     provider_var(provider)
     |> System.get_env
-    |> ensure_boolean
+    |> is_set?
   end
 
+  defp is_set?(val), do: not(is_nil(val))
+
 end
diff --git a/test/controllers/v1/chat_handle_controller_test.exs b/test/controllers/v1/chat_handle_controller_test.exs
@@ -62,14 +62,14 @@ defmodule Cog.V1.ChatHandleControllerTest do
   end
 
   test "fails if chat adapter for provider is not running", params do
-    chat_provider = "slack"
+    chat_provider = "not_a_real_provider"
     {:ok, chat} = Cog.Util.Misc.chat_adapter_module
     refute chat_provider == chat
 
     conn = api_request(params.authed,
                        :post, "/v1/users/#{params.authed.id}/chat_handles",
                        body: %{"chat_handle" => %{handle: "badnews",
-                                                  chat_provider: "slack"}})
+                                                  chat_provider: chat_provider}})
     assert json_response(conn, 422)["errors"]
   end