Skip to content

Commit

Permalink
Fix wrong assertion in libzfs diff error handling
Browse files Browse the repository at this point in the history
In compare(), all error cases set the error code to EPIPE, so when an
error is set, the correct assertion to make is that the error is EPIPE,
not EINVAL.

Reviewed-by: Richard Elling <Richard.Elling@RichardElling.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ryan Moeller <ryan@freqlabs.com>
Closes #8743
  • Loading branch information
Ryan Moeller authored and lundman committed May 27, 2019
1 parent 1aed18d commit 9cc1293
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion ZFSin/zfs/lib/libzfs/libzfs_diff.c
Original file line number Diff line number Diff line change
Expand Up @@ -482,7 +482,7 @@ differ(void *arg)
if (err)
return ((void *)-1);
if (di->zerr) {
ASSERT(di->zerr == EINVAL);
ASSERT(di->zerr == EPIPE);
(void) snprintf(di->errbuf, sizeof (di->errbuf),
dgettext(TEXT_DOMAIN,
"Internal error: bad data from diff IOCTL"));
Expand Down

0 comments on commit 9cc1293

Please sign in to comment.