Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix HloRunnerAgnosticTestBase includes. #21065

Merged
merged 1 commit into from
Jan 8, 2025
Merged

Conversation

copybara-service[bot]
Copy link

@copybara-service copybara-service bot commented Jan 6, 2025

Fix HloRunnerAgnosticTestBase includes.

Many of the tests that extend HloTestBase rely on symbols included
transitively. The main ones are:

  • PlatformUtil
  • LiteralUtil
  • LiteralTestUtil

This patch adds includes for these explicitly.

@copybara-service copybara-service bot force-pushed the test_712656979 branch 2 times, most recently from be74b76 to e457606 Compare January 7, 2025 19:28
@copybara-service copybara-service bot changed the title Fix HloRunnerAgnosticTestBase includes. Fix HloRunnerAgnosticTestBase includes. Jan 7, 2025
@copybara-service copybara-service bot force-pushed the test_712656979 branch 3 times, most recently from 1829aae to c663344 Compare January 7, 2025 23:50
Many of the tests that extend `HloTestBase` rely on symbols included
transitively.  The main ones are:

- `PlatformUtil`
- `LiteralUtil`
- `LiteralTestUtil`

This patch adds includes for these explicitly.

PiperOrigin-RevId: 713079045
@copybara-service copybara-service bot merged commit d1f63e2 into main Jan 8, 2025
@copybara-service copybara-service bot deleted the test_712656979 branch January 8, 2025 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant