[nfc] Cleanup build files for simplifier transforms #20595

shraiysh · 2024-12-16T21:36:37Z

This is part-2 of #18785.

Motivation: Smaller build files, fewer merge conflicts, and convinience in development (more intuitive targets). For discussion surrounding this, check thread in #18785.

shraiysh · 2024-12-24T17:08:22Z

Ping for review.

shraiysh · 2024-12-28T16:50:45Z

Hey @GleasonK, what is the internal error for the failed job?

This is part-2 of openxla#18785. Motivation: Smaller build files, fewer merge conflicts, and convinience in development (more intuitive targets).

Imported from GitHub PR openxla/xla#20595 This is part-2 of #18785. Motivation: Smaller build files, fewer merge conflicts, and convinience in development (more intuitive targets). For discussion surrounding this, check thread in #18785. Copybara import of the project: -- 8e547580014fc3686e4bbaeadd4561de36f426df by Shraiysh Vaishay <svaishay@nvidia.com>: [nfc] Cleanup build files for simplifier transforms This is part-2 of openxla/xla#18785. Motivation: Smaller build files, fewer merge conflicts, and convinience in development (more intuitive targets). Merging this change closes #20595 FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#20595 from shraiysh:cleanup_simplifier_build_files 8e547580014fc3686e4bbaeadd4561de36f426df PiperOrigin-RevId: 711650792

Imported from GitHub PR #20595 This is part-2 of #18785. Motivation: Smaller build files, fewer merge conflicts, and convinience in development (more intuitive targets). For discussion surrounding this, check thread in #18785. Copybara import of the project: -- 8e54758 by Shraiysh Vaishay <svaishay@nvidia.com>: [nfc] Cleanup build files for simplifier transforms This is part-2 of #18785. Motivation: Smaller build files, fewer merge conflicts, and convinience in development (more intuitive targets). Merging this change closes #20595 FUTURE_COPYBARA_INTEGRATE_REVIEW=#20595 from shraiysh:cleanup_simplifier_build_files 8e54758 PiperOrigin-RevId: 711650792

Imported from GitHub PR openxla/xla#20595 This is part-2 of #18785. Motivation: Smaller build files, fewer merge conflicts, and convinience in development (more intuitive targets). For discussion surrounding this, check thread in #18785. Copybara import of the project: -- 8e547580014fc3686e4bbaeadd4561de36f426df by Shraiysh Vaishay <svaishay@nvidia.com>: [nfc] Cleanup build files for simplifier transforms This is part-2 of openxla/xla#18785. Motivation: Smaller build files, fewer merge conflicts, and convinience in development (more intuitive targets). Merging this change closes #20595 FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#20595 from shraiysh:cleanup_simplifier_build_files 8e547580014fc3686e4bbaeadd4561de36f426df PiperOrigin-RevId: 711650792

akuegel · 2025-01-03T14:00:40Z

Regarding the question of internal failures: I haven't checked yet, but I suppose we need to adapt some internal BUILD files as well to account for the moved BUILD targets.

I have done the internal adjustments, but getting this landed turns out tricky. There are a bunch of presubmits failing only due to my lack of authorization to run them. So I fear I will need to introduce alias targets (already started with that) so that we can land just the open source side of the changes, and do the internal stuff one by one later.

shraiysh · 2025-01-03T19:06:44Z

Regarding the question of internal failures: I haven't checked yet, but I suppose we need to adapt some internal BUILD files as well to account for the moved BUILD targets.

I have done the internal adjustments, but getting this landed turns out tricky. There are a bunch of presubmits failing only due to my lack of authorization to run them. So I fear I will need to introduce alias targets (already started with that) so that we can land just the open source side of the changes, and do the internal stuff one by one later.

Sounds good. Please let me know if I need to do something on my end.