Add cargo check on CI

[WilliamTakeshi]

This PR introduces cargo check.

My plan is to gradually increase the coverage over multiple PRs and eventually add Clippy. Through these changes, I'm also familiarizing myself with the codebase.

• fix: cargo check unexpected_cfgs remove unnused cfgs (https://doc.rust-lang.org/nightly/rustc/check-cfg/cargo-specifics.html)
• fix: dead_code and unnecessary mut add _ on unused vars and remove unnecessary muts
• chore: allow deprecated for from_int_raw I'm marking fine the use of some deprecated functions for now, until we have a easy replacement

[chrysn]

That looks like a good change as a whole.

[chrysn]

I think this should be --workspace, and eventually fail (and not just show, nobody reads CI logs) if something is spotted.

Currently, wouldn't go through due to lakers-c apparently being embedded-only, but that should be fixable.

[chrysn]

… and maybe with a second --all-features pass, but that too currently fails :-/

[WilliamTakeshi]

Hey @chrysn , thanks for the feedback!

I’ve added RUSTFLAGS=-Dwarnings to the CI so that any warnings will now cause the build to fail.

I also added the --all-features flag to the check. The main change is in how the Crypto type is selected. Previously, the features "psa", "rustcrypto", and "cryptocell310" were mutually exclusive. I’ve switched to using cfg_if! to make them additive instead — though this introduces an implicit priority order. Let me know if the project prefers to keep them mutually exclusive instead.

I plan to add --workspace in the future, but for now I’m holding off as I’m not yet confident making changes to that part.

[geonnave]

Thanks for this PR, improving warnings and cleaning the codebase is very welcome.

I just saw emails that some of my github tokens expired. I just updated them. I hope the CI will be ok!

(I am in the middle of some weeks of mission abroad / PTO, doing some catch up now!)