Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gsmlib: Make version apk compatible #890

Merged
merged 1 commit into from
Nov 21, 2024
Merged

gsmlib: Make version apk compatible #890

merged 1 commit into from
Nov 21, 2024

Conversation

hnyman
Copy link
Contributor

@hnyman hnyman commented Nov 18, 2024

Adjust version to be compatible with apk's semantic rules.
Currently gsmlib is failing in buildbot, and also then apparently also breaking freeswitch.
https://downloads.openwrt.org/snapshots/faillogs/aarch64_cortex-a53/telephony/gsmlib/compile.txt

ERROR: info field 'version' has invalid value: package version is invalid
ERROR: failed to create package: /builder/shared-workdir/build/sdk/bin/packages/aarch64_cortex-a53/telephony/gsmlib-1.10-20140304-r5.apk: package version is invalid
make[3]: *** [Makefile:122: /builder/shared-workdir/build/sdk/bin/packages/aarch64_cortex-a53/telephony/gsmlib-1.10-20140304-r5.apk] Error 99

Needed change should be easy, as the actual code specification is by git hash, and version is just information.

Maintainer: nobody
cc @Ansuel @jslachta @micmac1
Compile tested: hopefully CI

@hnyman
Copy link
Contributor Author

hnyman commented Nov 18, 2024

CI apparently misses gettext-full...

compile-tested ok for mediatek/mt7622 RT3200

perus@ub2410:/OpenWrt/e8450$ ls bin/packages/aarch64_cortex-a53/telephony/
gsmlib-1.10.20140304-r5.apk  index.json  packages.adb  tmp

@hnyman
Copy link
Contributor Author

hnyman commented Nov 21, 2024

anybody still here with merge rights?

@jslachta
Copy link
Contributor

Yup, here. Going to merge this today.

@jslachta
Copy link
Contributor

Hi Hannu (@hnyman),

I believe changing the PKG_VERSION variable will result in a different package checksum. I’m not entirely sure, but in this case, I would suggest bumping the PKG_RELEASE.

Otherwise, it looks good to go.

Kind regards,
Jiri

@hnyman
Copy link
Contributor Author

hnyman commented Nov 21, 2024

I believe changing the PKG_VERSION variable will result in a different package checksum. I’m not entirely sure, but in this case, I would suggest bumping the PKG_RELEASE.

Note that "major version item" PKG_VERSION changes, so the "minor version item" PKG_RELEASE is actually irrelevant. I left that unchanged at 5, but it also could be argued to be resetted back to 1 (as PKG_VERSION did change).

But if you want, I can change that to 6. (EDIT: Done.)

Adjust version to be compatible with apk's semantic rules.

Signed-off-by: Hannu Nyman <hannu.nyman@iki.fi>
@jslachta jslachta merged commit 2933d00 into openwrt:master Nov 21, 2024
2 of 12 checks passed
@jslachta
Copy link
Contributor

Thank you!

@hnyman hnyman deleted the gsm branch November 22, 2024 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants