Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

luci-mod-status: Adding scroll buttons on syslog and kernellog status pages #6904

Merged
merged 1 commit into from
Feb 11, 2024

Conversation

Ramon00
Copy link
Contributor

@Ramon00 Ramon00 commented Feb 11, 2024

My log files can grow rather big, typically if i look at the log files then i want to look at the bottom, not the top, so I was missing a scroll down button.

So I added these:
image

image

Please let me know if you have any comments or suggestions.

@Ramon00 Ramon00 marked this pull request as ready for review February 11, 2024 12:27
@systemcrash
Copy link
Contributor

systemcrash commented Feb 11, 2024 via email

@Ramon00
Copy link
Contributor Author

Ramon00 commented Feb 11, 2024

@systemcrash yes i use that, but sometimes I want to just check the log from my phone, then i have to scroll all the way down... Anyway if you think this is not a good addition then fine, just reject this PR, i will just use it on my own openwrt installs, just thought it might be useful for somebody else as well. Not sure though why we would not want to make the LuCi logfile page more useful... Or do you mean I can use tail from LuCi? Please tell me how.

@hnyman
Copy link
Contributor

hnyman commented Feb 11, 2024

do you mean I can use tail from LuCi? Please tell me how.

Example of reversing log.
https://forum.openwrt.org/t/status-system-log-new-text-should-be-at-the-top-not-bottom/151740/4

@Ramon00
Copy link
Contributor Author

Ramon00 commented Feb 11, 2024

@systemcrash Which package is that in?

@systemcrash
Copy link
Contributor

systemcrash commented Feb 11, 2024 via email

@jow-
Copy link
Contributor

jow- commented Feb 11, 2024

The button style looks wrong

@Ramon00
Copy link
Contributor Author

Ramon00 commented Feb 11, 2024

@jow- if you can show me an example what button style you would like, then I can adjust it, np. I just put in the most simple button i could find

@Ramon00
Copy link
Contributor Author

Ramon00 commented Feb 11, 2024

@jow- Like this perhaps:
image

@Ramon00 Ramon00 force-pushed the syslog-button branch 2 times, most recently from aa02235 to 6395e21 Compare February 11, 2024 15:35
@systemcrash
Copy link
Contributor

systemcrash commented Feb 11, 2024

I just tested this, and it seems to work fine. Can you put a bit more padding between scroll to tail button and the log field?

@Ramon00
Copy link
Contributor Author

Ramon00 commented Feb 11, 2024

@systemcrash I encapsulated the bottom button now in a div and added 20px padding below the button. The padding between the button and the logfile itself is in the 'textarea' already, so i cannot really remove it. I can also add paddint to the top button either at above and/or below the button. Just a matter of what the preference is i suppose

@systemcrash
Copy link
Contributor

@systemcrash I encapsulated the bottom button now in a div and added 20px padding below the button. The padding between the button and the logfile itself is in the 'textarea' already, so i cannot really remove it. I can also add paddint to the top button either at above and/or below the button. Just a matter of what the preference is i suppose

Below the botton at the top, so it's not adjoining the log field

@Ramon00
Copy link
Contributor Author

Ramon00 commented Feb 11, 2024

Ah you didnt mean the scroll to head button, but the scroll to tail button. Something like this?
image
and
image

@systemcrash
Copy link
Contributor

Exactly so

@Ramon00
Copy link
Contributor Author

Ramon00 commented Feb 11, 2024

ok cool.

@systemcrash
Copy link
Contributor

Please rebase onto current master.

… pages

Signed-off-by: Ramon Van Gorkom <Ramon00c00@gmail.com>
@Ramon00
Copy link
Contributor Author

Ramon00 commented Feb 11, 2024

Please rebase onto current master.

done

@systemcrash systemcrash merged commit eb6b2bd into openwrt:master Feb 11, 2024
5 checks passed
@systemcrash
Copy link
Contributor

Thank you, nicely done :)

@Ramon00
Copy link
Contributor Author

Ramon00 commented Feb 11, 2024

And thank you for the review and the suggestions :)

@Ramon00 Ramon00 deleted the syslog-button branch October 17, 2024 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants