-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
luci-mod-status: Adding scroll buttons on syslog and kernellog status pages #6904
Conversation
Might I suggest Tail and Head, especially for those who might already be
familiar with those utilities that do exactly these things.
|
@systemcrash yes i use that, but sometimes I want to just check the log from my phone, then i have to scroll all the way down... Anyway if you think this is not a good addition then fine, just reject this PR, i will just use it on my own openwrt installs, just thought it might be useful for somebody else as well. Not sure though why we would not want to make the LuCi logfile page more useful... Or do you mean I can use tail from LuCi? Please tell me how. |
Example of reversing log. |
@systemcrash Which package is that in? |
I meant just to rename the strings, not invoke the utilities. :)
|
The button style looks wrong |
@jow- if you can show me an example what button style you would like, then I can adjust it, np. I just put in the most simple button i could find |
@jow- Like this perhaps: |
aa02235
to
6395e21
Compare
modules/luci-mod-status/htdocs/luci-static/resources/view/status/syslog.js
Outdated
Show resolved
Hide resolved
6395e21
to
25eeb40
Compare
I just tested this, and it seems to work fine. Can you put a bit more padding between scroll to tail button and the log field? |
25eeb40
to
c2a2d78
Compare
@systemcrash I encapsulated the bottom button now in a div and added 20px padding below the button. The padding between the button and the logfile itself is in the 'textarea' already, so i cannot really remove it. I can also add paddint to the top button either at above and/or below the button. Just a matter of what the preference is i suppose |
Below the botton at the top, so it's not adjoining the log field |
Exactly so |
c2a2d78
to
226d47e
Compare
ok cool. |
226d47e
to
03a5893
Compare
Please rebase onto current master. |
… pages Signed-off-by: Ramon Van Gorkom <Ramon00c00@gmail.com>
03a5893
to
64dbfb8
Compare
done |
Thank you, nicely done :) |
And thank you for the review and the suggestions :) |
My log files can grow rather big, typically if i look at the log files then i want to look at the bottom, not the top, so I was missing a scroll down button.
So I added these:
![image](https://private-user-images.githubusercontent.com/18365965/303913672-1e470b16-9e61-4b0b-836d-8c23d9404cf9.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkzOTk0OTEsIm5iZiI6MTczOTM5OTE5MSwicGF0aCI6Ii8xODM2NTk2NS8zMDM5MTM2NzItMWU0NzBiMTYtOWU2MS00YjBiLTgzNmQtOGMyM2Q5NDA0Y2Y5LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTIlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjEyVDIyMjYzMVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTNjMzU2NGFlYTJjYjQwMjczYjEyODA3MWJjYjUxMjY4MTE0Y2I4NjNmNTMzNDRhMTRiNDBhMDM0NmE0ZGNhYjYmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.AyNISQTQx8uHHM5ATcSIM30mOGKRDxJ0kXQV82911c4)
Please let me know if you have any comments or suggestions.