luci-app-smartdns: Fix The list has multiple headers. #6882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
|
Fix the checks please |
FanxJK
changed the title
FanxJK
changed the title
|
It's really much cleaner. Suggest merging. |
Suggest to read the checks and fixing those first. |
|
Almost. Now fix the commit |
Signed-off-by: FanxJK <fanxjk@gmail.com>
FanxJK
force-pushed
the
luci-app-smartdns-Fix-display
branch
from
2b1aad1 to
f77310c
Compare
|
Good. Merged. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before the fix:
After the fix:
@pymumu