luci-mod-network: dhcp tags improvements #6840
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jjm2473
commented
Jan 18, 2024
jjm2473
commented
- host tag add candidates
- add a tab for tags
Signed-off-by: Liangbin Lian <jjm2473@gmail.com>
Signed-off-by: Liangbin Lian <jjm2473@gmail.com>
jow-
reviewed
Jan 18, 2024
| _('Use tags to advertise different gateway and/or DNS to different hosts. Hosts can be associated with tags in "%s" tab').format(_('Static Leases')) + '<br />' + | ||
| _('DHCP Options') + ': ' + _('Define additional DHCP options, for example "<code>6,192.168.2.1,192.168.2.2</code>" which advertises different DNS servers to clients.') + | ||
| _('"<code>3,192.168.2.1</code>" which advertises different gateway to clients.') + '<br />' + | ||
| _('Note: Do not use "odhcpd" or network interface (such as "lan", "wan", "wan6", etc.) as name when adding tags, conflicts will occur. It is recommended to prefix the name with "t_" to avoid such conflicts.')); |
There was a problem hiding this comment.
We should add a section name validator to check for this. Iirc the generic logic will already ensure that a chosen section name is unique, in case it is not, we should add a validator.
There was a problem hiding this comment.
I have tested on 22.03, section name conflict occurs, sections with same name will be merged to a single section, the section type will be 'tag'
|
Closing in favour of #7178 (which includes this functionality) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.