Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

luci-proto-ipv6: dhcpv6.js fix translation #6751

Merged
merged 1 commit into from
Dec 7, 2023
Merged

luci-proto-ipv6: dhcpv6.js fix translation #6751

merged 1 commit into from
Dec 7, 2023

Conversation

try496
Copy link
Contributor

@try496 try496 commented Dec 6, 2023

No description provided.

@systemcrash
Copy link
Contributor

@try496

: === Checking commit '32c0ba1f33add3c43139549a93b7b8c8afa24b5c'
: Author name (try496) need to be your real name 'firstname lastname'
: Commit subject line seems ok (luci-proto-ipv6: dhcpv6.js fix translation)
: Signed-off-by is missing or doesn't match author (should be 'Signed-off-by: try496 <66765024+try496@users.noreply.github.com>')

Signed-off-by: he ping <pinghejk@gmail.com>
@try496
Copy link
Contributor Author

try496 commented Dec 7, 2023

@systemcrash Modification completed

@systemcrash systemcrash merged commit 2065ead into openwrt:master Dec 7, 2023
@systemcrash
Copy link
Contributor

Great, thanks!

@try496 try496 deleted the dhcpv6 branch December 7, 2023 08:58
@jow-
Copy link
Contributor

jow- commented Dec 7, 2023

That merge was a bit premature, I wanted to point out that the translations should contain a context, since try, force and disabled alone are very broad and ambiguous.

Edit: it also contains syntax errors! Commit author does not match S-o-b either...

jow- added a commit that referenced this pull request Dec 7, 2023
This reverts commit 2065ead.

The commit contains syntax errors despite two reviews and was apparently
not runtime tested at all.

Signed-off-by: Jo-Philipp Wich <jo@mein.io>
jow- added a commit that referenced this pull request Dec 7, 2023
Fixes: #6730, #6751
Fixes: 2065ead ("luci-proto-ipv6: dhcpv6.js fix translation (#6751)")
Suggested-by: he ping <pinghejk@gmail.com>
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
@systemcrash
Copy link
Contributor

systemcrash commented Dec 7, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants