Luci-app-zerotier:First version of luci-app-zerotier #6732
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you please just rebase the first commit on master, and not do a merge commit? |
systemcrash
requested changes
Dec 4, 2023
| fi | ||
|
|
||
| if [ "$secret" = "generate" ]; then | ||
| echo "Generate secret - please wait..." |
There was a problem hiding this comment.
Is this present tense "Generating"?
|
Hi @pprindeville could you give these startup scripts your blessing? |
The first time you make a submission, how to do this work? |
vpei
commented
Dec 4, 2023
|
. |
|
Please drop the merges. Use |
Tried to review it, but I don't know Javascript... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Luci-app-zerotier:First version of luci-app-zerotier