luci-app-statistics: harden sysupgrade_backup #6688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hnyman have a look. Given that sysupgrade_backup is really for internal use, perhaps I should remove it from the help and only document the 'backup' option? |
|
I simultaneously said in #6646 (comment) ;-)
Yes, please remove it. |
Remove sysupgrade_backup from help. Also have it check parameters. Signed-off-by: John Kohl <jtk.git@bostonpog.org>
jtkohl
force-pushed
the
harden-sysupgrade_backup
branch
from
9974b60 to
94cd148
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve the help for sysupgrade_backup and have it check parameters