Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

luci-app-apfree-wifidog: add luci-app-apfree-wifidog #6412

Closed
wants to merge 1 commit into from
Closed

luci-app-apfree-wifidog: add luci-app-apfree-wifidog #6412

wants to merge 1 commit into from

Conversation

liudf0716
Copy link
Contributor

add luci-app-apfree-wifidog for apfree-wifidog
openwrt/packages#21203

feckert
feckert previously requested changes Jun 15, 2023
View reviewed changes
Copy link
Member

@feckert feckert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything else looks good.

@liudf0716 liudf0716 requested a review from feckert June 19, 2023 08:20
@liudf0716
Copy link
Contributor Author

@feckert What else can I do to get my pull request approved?

@liudf0716 liudf0716 mentioned this pull request Jul 23, 2023
Closed
@liudf0716
Copy link
Contributor Author

Hi @feckert, I submitted the PR nearly four months ago, and I'm uncertain about what additional changes are needed to meet your requirements. Could you please provide guidance on the specific adjustments required? I genuinely appreciate any advice you can offer. Thank you.

@systemcrash
Copy link
Contributor

Fix those changes and LGTM

@liudf0716
luci-app-apfree-wifidog: add luci-app-apfree-wifidog
d49dd8f 
Signed-off-by: Dengfeng Liu <liudf0716@gmail.com>
@liudf0716
Copy link
Contributor Author

@systemcrash
Thank you so much for reviewing my code! I've implemented the modifications you suggested, and I'm pleased to let you know that I've completed the changes. Your insights were invaluable. I appreciate your time and expertise!

@systemcrash systemcrash added feature pull request adding a new feature New package New package for the repository Work needed Needs work by the pullrequest creator labels Dec 4, 2023
@liudf0716
Copy link
Contributor Author

@systemcrash @feckert
What other actions should I take? I noticed the "work needed" label on the pull request. thanks

@systemcrash
Copy link
Contributor

@systemcrash @feckert What other actions should I take? I noticed the "work needed" label on the pull request. thanks

Change that string and we can merge

@systemcrash systemcrash marked this pull request as draft December 30, 2023 23:40
@liudf0716
Copy link
Contributor Author

@systemcrash @feckert What other actions should I take? I noticed the "work needed" label on the pull request. thanks

Change that string and we can merge

I'm sorry, I'm not sure which specific string you're referring to. Could you please provide more context or identify the exact string you'd like me to change? I was under the impression that I had already made all the necessary changes, but I'm happy to double-check and make any further adjustments.

@systemcrash
Copy link
Contributor

I'm sorry, I'm not sure which specific string you're referring to. Could you please provide more context or identify the exact string you'd like me to change? I was under the impression that I had already made all the necessary changes, but I'm happy to double-check and make any further adjustments.

Look through this PR again, and resolve the outstanding review.

@liudf0716 liudf0716 marked this pull request as ready for review January 15, 2024 03:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@systemcrash systemcrash systemcrash approved these changes

@feckert feckert Awaiting requested review from feckert

Assignees
No one assigned
Labels
feature pull request adding a new feature New package New package for the repository Work needed Needs work by the pullrequest creator
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@liudf0716 @systemcrash @feckert