[CPU] Replace OPENVINO_ASSERT macros usage in nodes with CPU_NODE_ASSERT #28872
+99
−135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxnick
requested changes
Feb 7, 2025
Comment on lines
728
to
731
| CPU_NODE_ASSERT(baseDim != Shape::UNDEFINED_DIM, | ||
| " Concat node: ", | ||
| getName(), | ||
| " can't use inPlace memory with concatenation on dynamic dimension"); |
There was a problem hiding this comment.
Please remove the node type and name from the message as it's incerted in the prefix (see CPU_NODE_ASSERT macro). Here and below.
| @@ -571,21 +571,21 @@ void Split::resolveInPlaceEdges(Edge::LOOK look) { | |||
| size_t numberOfOutputs = config.outConfs.size(); | |||
| size_t inplaceInpIndx = selected_pd->getConfig().outConfs[0].inPlace(); | |||
| auto baseDim = inputShapes.front().getDims()[axis]; | |||
| OPENVINO_ASSERT(baseDim != Shape::UNDEFINED_DIM, | |||
| CPU_NODE_ASSERT(baseDim != Shape::UNDEFINED_DIM, | |||
There was a problem hiding this comment.
Please remove the node name and type.
maxnick
reviewed
Feb 7, 2025
maxnick
approved these changes
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details:
Tickets: