Use OV RTTI for ConversionExtensions

[ilya-lavrenov]

Details:

• Use OV RTTI for ConversionExtensions

Tickets:

• CVS-160510

[ilya-lavrenov]

@t-jankowski I see that in some places we need to use custom RTTI declaration to ensure it's marked as virtual

Can we expend OPENVINO_RTTI for such cases ? I suppose default OPENVINO_RTTI does not provide virtual? should we have something like OPENVINO_RTTI_BASE_CLASS or similar ? to denote that we later want to override definitions

[t-jankowski]

Yes, OPENVINO_RTTI_BASE_CLASS would enforce virtual for get_type_info. I'll make it.

[t-jankowski]

Addressed in #28911

[rkazants]

comment left

[ilya-lavrenov]

@olpipi @rkazants @t-jankowski @praasz please, review

[olpipi]

I find it a bit odd that we have common code that depends on some specific details. (as_type_ptr depends on ov::frontend::ConversionExtensionBase).

I'd suggest to add special conversion func for ConversionExtensions into src/frontends/common/include/openvino/frontend/extension/conversion.hpp. And use it from FEs instead of as_type_ptr.
Smth like that:

template <typename Type, typename Value, typename = std::enable_if_t<std::is_base_of_v<ConversionExtensionBase, Type>>>
auto conversion_extension_as_type_ptr(const Value& value) -> decltype(::ov::util::AsTypePtr<Value>::template call<Type>(value)) {
        return ::ov::util::AsTypePtr<Value>::template call<Type>(value);
}

But if everyone else is ok with it, then OK :)

[t-jankowski]

I agree with the conclusion. As of solution I'd apply some type traits based on integral_const.

No comments anymore