[CPU] Fix google-default-arguments clang-tidy remarks

src/common/snippets/include/snippets/emitter.hpp

@@ -52,16 +52,21 @@ class Emitter {
 
     /**
      * @brief called by generator to generate code to produce target code for a specific operation
+     * @details
+     *   Avoid passing default arguments to virtual function, but still allow user to call
+     *   emit_code function without "pool" or "gpr"
      * @param in vector of vector argument registers
      * @param out vector of vector resulting registers
      * @param pool optional vector of free vector registers which might be used inside method
-     * @param gpr vector of free generam puproce registers which might be used inside method
+     * @param gpr vector of free general purpose registers which might be used inside method
      * @return void
      */
-    virtual void emit_code(const std::vector<size_t>& in,
-                           const std::vector<size_t>& out,
-                           const std::vector<size_t>& pool = {},
-                           const std::vector<size_t>& gpr  = {}) const = 0;
+    void emit_code(const std::vector<size_t>& in,
+                        const std::vector<size_t>& out,
+                        const std::vector<size_t>& pool = {},
+                        const std::vector<size_t>& gpr = {}) const {
+        emit_code_impl(in, out, pool, gpr);
+    }
 
     /**
      * @brief called by generator to generate data section, if needed for a specific operation
@@ -70,6 +75,20 @@ class Emitter {
     virtual void emit_data() const {}
 
     virtual ~Emitter() = default;
+
+private:
+    /**
+     * @brief called by generator to generate code to produce target code for a specific operation
+     * @param in vector of vector argument registers
+     * @param out vector of vector resulting registers
+     * @param pool optional vector of free vector registers which might be used inside method
+     * @param gpr vector of free general purpose registers which might be used inside method
+     * @return void
+     */
+    virtual void emit_code_impl(const std::vector<size_t>& in,
+                                const std::vector<size_t>& out,
+                                const std::vector<size_t>& pool,
+                                const std::vector<size_t>& gpr) const = 0;
 };
 
 } // namespace snippets

src/common/snippets/tests/include/lowering_utils.hpp

@@ -19,11 +19,12 @@ using BlockedShapeVector = ov::snippets::op::Subgraph::BlockedShapeVector;
 class DummyEmitter : public ov::snippets::Emitter {
 public:
     DummyEmitter(const std::vector<ov::Node::type_info_t>& custom_opset = {}) : ov::snippets::Emitter() {}
-    void emit_code(const std::vector<size_t>&,
-                   const std::vector<size_t>&,
-                   const std::vector<size_t>&,
-                   const std::vector<size_t>&) const override {}
     void emit_data() const override {}
+protected:
+    void emit_code_impl(const std::vector<size_t>&,
+                        const std::vector<size_t>&,
+                        const std::vector<size_t>&,
+                        const std::vector<size_t>&) const override {}
 };
 
 struct DummyCompiledSnippet : public ov::snippets::CompiledSnippet {

src/plugins/intel_cpu/src/.clang-tidy

@@ -46,7 +46,6 @@ Checks: >
   -cppcoreguidelines-narrowing-conversions,
   -cppcoreguidelines-pro-bounds-pointer-arithmetic,
   -google-build-using-namespace,
-  -google-default-arguments,
   -google-explicit-constructor,
   -google-readability-casting,
   -google-readability-todo,

src/plugins/intel_cpu/src/cpu_memory.h

@@ -188,7 +188,7 @@ class IMemory {
     // Caution!!! This action invalidates the previous data layout. The old data may become unreachable.
     virtual void redefineDesc(MemoryDescPtr desc) = 0;
 
-    virtual void load(const IMemory& src, bool ftz = true) const = 0;
+    virtual void load(const IMemory& src, bool ftz) const = 0;
 
     virtual MemoryBlockPtr getMemoryBlock() const = 0;
 
@@ -260,7 +260,7 @@ class StaticMemory final : public IMemory {
     // Always throws since a static memory descriptor should not be modified
     void redefineDesc(MemoryDescPtr desc) override;
 
-    void load(const IMemory& src, bool ftz = true) const override;
+    void load(const IMemory& src, bool ftz) const override;
 
     MemoryBlockPtr getMemoryBlock() const override;
 
@@ -315,7 +315,7 @@ class Memory : public IMemory {
 
     void redefineDesc(MemoryDescPtr desc) override;
 
-    void load(const IMemory& src, bool ftz = true) const override;
+    void load(const IMemory& src, bool ftz) const override;
     void nullify() override;
 
     dnnl::engine getEngine() const {
@@ -421,7 +421,7 @@ class StringMemory : public IMemory {
 
     void redefineDesc(MemoryDescPtr desc) override;
 
-    void load(const IMemory& src, bool ftz = false) const override;
+    void load(const IMemory& src, bool ftz) const override;
 
     MemoryBlockPtr getMemoryBlock() const override;
 

src/plugins/intel_cpu/src/cpu_tensor.h

@@ -27,7 +27,7 @@ class Tensor : public ITensor {
 
     const ov::Strides& get_strides() const override;
 
-    void* data(const element::Type& type = {}) const override;
+    void* data(const element::Type& type) const override;
 
     MemoryPtr get_memory() {
         return m_memptr;

src/plugins/intel_cpu/src/dnnl_postops_composer.cpp

@@ -660,7 +660,7 @@ static MemoryPtr prepackDecompressionParams(const MemoryCPtr& paramsPtr,
         srcFormat);
     auto srcMem = std::make_shared<Memory>(engine, srcMemoryDesc, paramsPtr->getData());
 
-    dstMem->load(*srcMem);
+    dstMem->load(*srcMem, true);
     return dstMem;
 }
 

src/plugins/intel_cpu/src/emitters/plugin/aarch64/jit_emitter.cpp

@@ -45,10 +45,10 @@ const std::vector<size_t> jit_emitter::store_gpr_regs = {
 static const std::vector<size_t> vec_regs = {0,  1,  2,  3,  4,  5,  6,  7,  8,  9,  10, 11, 12, 13, 14, 15,
                                              16, 17, 18, 19, 20, 21, 22, 23, 24, 25, 26, 27, 28, 29, 30, 31};
 
-void jit_emitter::emit_code(const std::vector<size_t>& in_idxs,
-                            const std::vector<size_t>& out_idxs,
-                            const std::vector<size_t>& pool_vec_idxs,
-                            const std::vector<size_t>& pool_gpr_idxs) const {
+void jit_emitter::emit_code_impl(const std::vector<size_t>& in_idxs,
+                                 const std::vector<size_t>& out_idxs,
+                                 const std::vector<size_t>& pool_vec_idxs,
+                                 const std::vector<size_t>& pool_gpr_idxs) const {
     emitter_preamble(in_idxs, out_idxs, pool_vec_idxs, pool_gpr_idxs);
 
     emit_impl(in_idxs, out_idxs);

src/plugins/intel_cpu/src/emitters/plugin/aarch64/jit_emitter.hpp

@@ -50,11 +50,6 @@ class jit_emitter : public ov::snippets::Emitter {
           p_table(0),
           l_table(new Xbyak_aarch64::Label()) {}
 
-    void emit_code(const std::vector<size_t>& in_idxs,
-                   const std::vector<size_t>& out_idxs,
-                   const std::vector<size_t>& pool_vec_idxs = {},
-                   const std::vector<size_t>& pool_gpr_idxs = {}) const override;
-
     void emit_data() const override;
 
     virtual size_t get_inputs_count() const = 0;
@@ -86,6 +81,11 @@ class jit_emitter : public ov::snippets::Emitter {
     virtual void prepare_table();
     virtual void register_table_entries() {}
 
+    void emit_code_impl(const std::vector<size_t>& in_idxs,
+                        const std::vector<size_t>& out_idxs,
+                        const std::vector<size_t>& pool_vec_idxs,
+                        const std::vector<size_t>& pool_gpr_idxs) const override;
+
     void load_table_addr() const {
         h->adr(p_table, *l_table.get());
     }

src/plugins/intel_cpu/src/emitters/plugin/x64/jit_dnnl_emitters.cpp

@@ -66,10 +66,10 @@ size_t jit_dnnl_emitter::get_inputs_num() const {
     return 1;
 }
 
-void jit_dnnl_emitter::emit_code(const std::vector<size_t>& in_vec_idxs,
-                                 const std::vector<size_t>& out_vec_idxs,
-                                 const std::vector<size_t>& pool_vec_idxs,
-                                 const std::vector<size_t>& pool_gpr_idxs) const {
+void jit_dnnl_emitter::emit_code_impl(const std::vector<size_t>& in_vec_idxs,
+                                      const std::vector<size_t>& out_vec_idxs,
+                                      const std::vector<size_t>& pool_vec_idxs,
+                                      const std::vector<size_t>& pool_gpr_idxs) const {
     if (host_isa_ == cpu::x64::sse41) {
         if (out_vec_idxs[0] != in_vec_idxs[0]) {
             h->uni_vmovups(Xmm(out_vec_idxs[0]), Xmm(in_vec_idxs[0]));

src/plugins/intel_cpu/src/emitters/plugin/x64/jit_dnnl_emitters.hpp

@@ -13,11 +13,6 @@ namespace intel_cpu {
 
 class jit_dnnl_emitter : public jit_emitter {
 public:
-    void emit_code(const std::vector<size_t>& in_vec_idxs,
-                   const std::vector<size_t>& out_vec_idxs,
-                   const std::vector<size_t>& pool_vec_idxs,
-                   const std::vector<size_t>& pool_gpr_idxs) const override;
-
     void emit_data() const override;
 
     void emit_impl(const std::vector<size_t>& in_idxs, const std::vector<size_t>& out_idxs) const override{};
@@ -38,6 +33,11 @@ class jit_dnnl_emitter : public jit_emitter {
                      ov::element::Type exec_prc = ov::element::f32);
     void set_injector();
 
+    void emit_code_impl(const std::vector<size_t>& in_vec_idxs,
+                        const std::vector<size_t>& out_vec_idxs,
+                        const std::vector<size_t>& pool_vec_idxs,
+                        const std::vector<size_t>& pool_gpr_idxs) const override;
+
     dnnl_alg_kind_t kind{dnnl_alg_kind_undef};
     float alpha{0.f};
     float beta{0.f};

src/plugins/intel_cpu/src/emitters/plugin/x64/jit_emitter.cpp

@@ -248,10 +248,10 @@ void jit_emitter::prepare_table() {
     }
 }
 
-void jit_emitter::emit_code(const std::vector<size_t>& in_idxs,
-                            const std::vector<size_t>& out_idxs,
-                            const std::vector<size_t>& pool_vec_idxs,
-                            const std::vector<size_t>& pool_gpr_idxs) const {
+void jit_emitter::emit_code_impl(const std::vector<size_t>& in_idxs,
+                                 const std::vector<size_t>& out_idxs,
+                                 const std::vector<size_t>& pool_vec_idxs,
+                                 const std::vector<size_t>& pool_gpr_idxs) const {
     emitter_preamble(in_idxs, out_idxs, pool_vec_idxs, pool_gpr_idxs);
 
     emit_impl(in_idxs, out_idxs);

src/plugins/intel_cpu/src/emitters/plugin/x64/jit_emitter.hpp

@@ -47,10 +47,6 @@ class jit_emitter : public ov::snippets::Emitter {
         k_mask = Xbyak::Opmask(1);  // FIXME: in general case we need preserve k_mask state as well
     }
 
-    void emit_code(const std::vector<size_t>& in_idxs,
-                   const std::vector<size_t>& out_idxs,
-                   const std::vector<size_t>& pool_vec_idxs = {},
-                   const std::vector<size_t>& pool_gpr_idxs = {}) const override;
     void emit_data() const override;
 
     virtual size_t get_inputs_num() const = 0;
@@ -84,6 +80,11 @@ class jit_emitter : public ov::snippets::Emitter {
     ov::element::Type exec_prc_;
     Xbyak::Opmask k_mask;
 
+    void emit_code_impl(const std::vector<size_t>& in_idxs,
+                        const std::vector<size_t>& out_idxs,
+                        const std::vector<size_t>& pool_vec_idxs,
+                        const std::vector<size_t>& pool_gpr_idxs) const override;
+
     virtual void prepare_table();
     virtual void register_table_entries() {}
 

src/plugins/intel_cpu/src/emitters/snippets/aarch64/jit_kernel_emitter.cpp

@@ -103,10 +103,10 @@ jit_kernel_emitter::jit_kernel_emitter(jit_generator* h,
     data_ptr_regs_idx = snippets::utils::transform_snippets_regs_to_idxs(data_ptr_regs, snippets::RegType::gpr);
 }
 
-void jit_kernel_emitter::emit_code(const std::vector<size_t>& in,
-                                   const std::vector<size_t>& out,
-                                   const std::vector<size_t>& pool_vec_idxs,
-                                   const std::vector<size_t>& pool_gpr_idxs) const {
+void jit_kernel_emitter::emit_code_impl(const std::vector<size_t>& in,
+                                        const std::vector<size_t>& out,
+                                        const std::vector<size_t>& pool_vec_idxs,
+                                        const std::vector<size_t>& pool_gpr_idxs) const {
     validate_arguments(in, out);
     aux_vec_idxs = pool_vec_idxs;
     aux_gpr_idxs = pool_gpr_idxs;

src/plugins/intel_cpu/src/emitters/snippets/aarch64/jit_kernel_emitter.hpp

@@ -38,10 +38,6 @@ class jit_kernel_emitter : public jit_emitter {
     size_t get_inputs_count() const override {
         return 0;
     }
-    void emit_code(const std::vector<size_t>& in_idxs,
-                   const std::vector<size_t>& out_idxs,
-                   const std::vector<size_t>& pool_vec_idxs,
-                   const std::vector<size_t>& pool_gpr_idxs) const override;
 
 protected:
     void validate_arguments(const std::vector<size_t>& in, const std::vector<size_t>& out) const override;
@@ -56,6 +52,11 @@ class jit_kernel_emitter : public jit_emitter {
     virtual void init_data_pointers(const std::vector<Xbyak_aarch64::XReg>& arg_regs,
                                     const std::vector<Xbyak_aarch64::XReg>& data_ptr_regs) const = 0;
 
+    void emit_code_impl(const std::vector<size_t>& in_idxs,
+                        const std::vector<size_t>& out_idxs,
+                        const std::vector<size_t>& pool_vec_idxs,
+                        const std::vector<size_t>& pool_gpr_idxs) const override;
+
     void emit_impl(const std::vector<size_t>& in, const std::vector<size_t>& out) const override;
 
     jit_snippets_compile_args jcp;

src/plugins/intel_cpu/src/emitters/snippets/aarch64/jit_loop_emitters.cpp

@@ -41,10 +41,10 @@ void jit_loop_begin_emitter::validate_arguments(const std::vector<size_t>& in, c
     OV_CPU_JIT_EMITTER_ASSERT(loop_begin_label != nullptr, "has not inited label!");
 }
 
-void jit_loop_begin_emitter::emit_code(const std::vector<size_t>& in,
-                                       const std::vector<size_t>& out,
-                                       const std::vector<size_t>& pool_vec_idxs,
-                                       const std::vector<size_t>& pool_gpr_idxs) const {
+void jit_loop_begin_emitter::emit_code_impl(const std::vector<size_t>& in,
+                                            const std::vector<size_t>& out,
+                                            const std::vector<size_t>& pool_vec_idxs,
+                                            const std::vector<size_t>& pool_gpr_idxs) const {
     validate_arguments(in, out);
     emit_impl(in, out);
 }
@@ -125,7 +125,7 @@ void jit_loop_end_emitter::validate_arguments(const std::vector<size_t>& in, con
     OV_CPU_JIT_EMITTER_ASSERT(loop_begin_label != nullptr, "has not inited begin label!");
 }
 
-void jit_loop_end_emitter::emit_code(const std::vector<size_t>& in,
+void jit_loop_end_emitter::emit_code_impl(const std::vector<size_t>& in,
                                      const std::vector<size_t>& out,
                                      const std::vector<size_t>& pool_vec_idxs,
                                      const std::vector<size_t>& pool_gpr_idxs) const {

src/plugins/intel_cpu/src/emitters/snippets/aarch64/jit_loop_emitters.hpp

@@ -22,12 +22,6 @@ class jit_loop_begin_emitter : public jit_emitter {
     size_t get_inputs_count() const override {
         return 0;
     }
-
-    void emit_code(const std::vector<size_t>& in_idxs,
-                   const std::vector<size_t>& out_idxs,
-                   const std::vector<size_t>& pool_vec_idxs = {},
-                   const std::vector<size_t>& pool_gpr_idxs = {}) const override;
-
     std::shared_ptr<const Xbyak_aarch64::Label> get_begin_label() {
         return loop_begin_label;
     }
@@ -36,6 +30,11 @@ class jit_loop_begin_emitter : public jit_emitter {
     void validate_arguments(const std::vector<size_t>& in, const std::vector<size_t>& out) const override;
     void emit_impl(const std::vector<size_t>& in, const std::vector<size_t>& out) const override;
 
+    void emit_code_impl(const std::vector<size_t>& in_idxs,
+                        const std::vector<size_t>& out_idxs,
+                        const std::vector<size_t>& pool_vec_idxs,
+                        const std::vector<size_t>& pool_gpr_idxs) const override;
+
     std::shared_ptr<Xbyak_aarch64::Label> loop_begin_label;
     size_t work_amount = 0;
     int64_t wa_increment = 0;
@@ -56,10 +55,10 @@ class jit_loop_end_emitter : public jit_emitter {
         return 0;
     }
 
-    void emit_code(const std::vector<size_t>& in_idxs,
+    void emit_code_impl(const std::vector<size_t>& in_idxs,
                    const std::vector<size_t>& out_idxs,
-                   const std::vector<size_t>& pool_vec_idxs = {},
-                   const std::vector<size_t>& pool_gpr_idxs = {}) const override;
+                   const std::vector<size_t>& pool_vec_idxs,
+                   const std::vector<size_t>& pool_gpr_idxs) const override;
 
 protected:
     void validate_arguments(const std::vector<size_t>& in, const std::vector<size_t>& out) const override;

src/plugins/intel_cpu/src/emitters/snippets/x64/jit_debug_emitter.cpp

@@ -60,10 +60,10 @@ void jit_debug_emitter::emit_impl(const std::vector<size_t>& in_idxs, const std:
     m_target_emitter->emit_impl(in_idxs, out_idxs);
 }
 
-void jit_debug_emitter::emit_code(const std::vector<size_t>& in_idxs,
-                                  const std::vector<size_t>& out_idxs,
-                                  const std::vector<size_t>& pool_vec_idxs,
-                                  const std::vector<size_t>& pool_gpr_idxs) const {
+void jit_debug_emitter::emit_code_impl(const std::vector<size_t>& in_idxs,
+                                       const std::vector<size_t>& out_idxs,
+                                       const std::vector<size_t>& pool_vec_idxs,
+                                       const std::vector<size_t>& pool_gpr_idxs) const {
     if (m_decorator_emit_loc == EmissionLocation::preamble || m_decorator_emit_loc == EmissionLocation::both) {
         m_decorator_emitter->emit_code(in_idxs, out_idxs, pool_vec_idxs, pool_gpr_idxs);
     }

src/plugins/intel_cpu/src/emitters/snippets/x64/jit_debug_emitter.hpp

@@ -29,10 +29,6 @@ class jit_debug_emitter : public jit_emitter {
         prepare_table();
     }
 
-    void emit_code(const std::vector<size_t>& in_idxs,
-                   const std::vector<size_t>& out_idxs,
-                   const std::vector<size_t>& pool_vec_idxs = {},
-                   const std::vector<size_t>& pool_gpr_idxs = {}) const override;
     void emit_data() const override;
 
     size_t get_inputs_num() const override;
@@ -46,6 +42,11 @@ class jit_debug_emitter : public jit_emitter {
 
     void emit_impl(const std::vector<size_t>& in_idxs, const std::vector<size_t>& out_idxs) const override;
 
+    void emit_code_impl(const std::vector<size_t>& in_idxs,
+                        const std::vector<size_t>& out_idxs,
+                        const std::vector<size_t>& pool_vec_idxs,
+                        const std::vector<size_t>& pool_gpr_idxs) const override;
+
     void emitter_preamble(const std::vector<size_t>& in_idxs,
                           const std::vector<size_t>& out_idxs,
                           const std::vector<size_t>& pool_vec_idxs,

src/plugins/intel_cpu/src/emitters/snippets/x64/jit_kernel_emitter.cpp

@@ -50,10 +50,10 @@ jit_kernel_emitter::jit_kernel_emitter(jit_generator* h,
     data_ptr_regs_idx = snippets::utils::transform_snippets_regs_to_idxs(data_ptr_regs, snippets::RegType::gpr);
 }
 
-void jit_kernel_emitter::emit_code(const std::vector<size_t>& in,
-                                   const std::vector<size_t>& out,
-                                   const std::vector<size_t>& pool_vec_idxs,
-                                   const std::vector<size_t>& pool_gpr_idxs) const {
+void jit_kernel_emitter::emit_code_impl(const std::vector<size_t>& in,
+                                        const std::vector<size_t>& out,
+                                        const std::vector<size_t>& pool_vec_idxs,
+                                        const std::vector<size_t>& pool_gpr_idxs) const {
     validate_arguments(in, out);
     aux_vec_idxs = pool_vec_idxs;
     aux_gpr_idxs = pool_gpr_idxs;