Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CPU] Fix google-default-arguments clang-tidy remarks #28772

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

[CPU] Fix google-default-arguments clang-tidy remarks #28772

wants to merge 4 commits into from
+192 −157

Conversation

aobolensk
Copy link
Contributor

@aobolensk aobolensk commented Jan 31, 2025 •
edited
Loading

Details:

  • Fix "google-default-arguments" issues reported by clang-tidy
  • Enable "google-default-arguments" clang-tidy checks on CI by default
  • Introduce "emit_code_impl" in JIT emitters to avoid default arguments in virtual methods

Tickets:

  • N/A

@aobolensk aobolensk requested review from a team as code owners January 31, 2025 19:05
@github-actions github-actions bot added the category: CPU OpenVINO CPU plugin label Jan 31, 2025
@aobolensk aobolensk force-pushed the fix-google-default-arguments branch from 854c928 to 48e038d Compare January 31, 2025 20:14
@EgorDuplensky
Copy link
Contributor

EgorDuplensky commented Feb 5, 2025 •
edited
Loading

@dmitry-gorokhov Could you please take a look
google-default-arguments is fixed in scope of separate commit since it was not so straightforward to resolve.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EgorDuplensky EgorDuplensky EgorDuplensky approved these changes

Assignees

@dmitry-gorokhov dmitry-gorokhov

Labels
category: CPU OpenVINO CPU plugin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aobolensk @EgorDuplensky @dmitry-gorokhov