[CPU] Enable clang-tidy-18 checks

[aobolensk]

Details:

• Enable clang-tidy check on clang-18 (default for Ubuntu 24.04)
• Fix newly appeared warnings

Tickets:

• N/A

[EgorDuplensky]

@ilya-lavrenov We want to bump up the version to 18. This is a default clang version on Ubuntu24. The reason - 18 version contains a feature misc-include-cleaner, which will allow us to fix most of the include mess and implicit include dependencies we have.
After we fix the includes, we will be able to implement an independent CI workflow for clang-tidy, which will only check the changed files independently and will not require to compile all the source files with clang-tidy enabled. Without fixing the includes those file-by-file checks may fail because of missing includes.
This will allow us to implement such workflow for all the architectures with very small execution time, basically it scales much better than building the whole project with clang-tidy.

The downside is that for clang-format we will have version 15 required, but for clang-tidy - version 18. And, for example, to install clang-tidy-18 on ubuntu22 it is required to add a ppa to apt sources. From my perspective these cons are not that important, since we already support Ubuntu24 where clang-tidy-18 is the default one.

What do you think?

[ilya-lavrenov]

I don't see a problem if we will use different versions of clang-family tools on different systems.
Once most of developers migrate to U24 as development machine, we can switch to clang-format-18

[EgorDuplensky]

@dmitry-gorokhov Ready to merge
Please check the following comment for the details:

• [CPU] Enable clang-tidy-18 checks #28725 (comment)