Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Torchfx weight int4pack mm initial support #28391

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

cavusmustafa
Copy link
Contributor

@cavusmustafa cavusmustafa commented Jan 12, 2025

Details:

  • Decomposition for aten._unsafe_index
  • Initial support for aten._weight_int4pack_mm.default

Tickets:

@github-actions github-actions bot added category: Python API OpenVINO Python bindings category: PyTorch FE OpenVINO PyTorch Frontend labels Jan 12, 2025
@cavusmustafa cavusmustafa modified the milestone: 2025.0 Jan 12, 2025
@cavusmustafa cavusmustafa marked this pull request as ready for review January 12, 2025 06:42
@cavusmustafa cavusmustafa requested review from a team as code owners January 12, 2025 06:42
Copy link
Contributor

@ynimmaga ynimmaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mvafin
Copy link
Contributor

mvafin commented Jan 16, 2025

There are build errors for this PR:

[ 85%] Building CXX object src/frontends/pytorch/src/CMakeFiles/openvino_pytorch_frontend.dir/utils_quantize.cpp.o
/__w/openvino/openvino/openvino/src/frontends/pytorch/src/transforms/torchfx_torchao_pattern_replacer.cpp:50:31: error: no matching constructor for initialization of 'std::vector<uint64_t>' (aka 'vector<unsigned long long>')
   50 |         std::vector<uint64_t> broadcast_shape_vec(wt_const_flat->get_shape());
      |                               ^                   ~~~~~~~~~~~~~~~~~~~~~~~~~~

@cavusmustafa
Copy link
Contributor Author

There are build errors for this PR:

[ 85%] Building CXX object src/frontends/pytorch/src/CMakeFiles/openvino_pytorch_frontend.dir/utils_quantize.cpp.o
/__w/openvino/openvino/openvino/src/frontends/pytorch/src/transforms/torchfx_torchao_pattern_replacer.cpp:50:31: error: no matching constructor for initialization of 'std::vector<uint64_t>' (aka 'vector<unsigned long long>')
   50 |         std::vector<uint64_t> broadcast_shape_vec(wt_const_flat->get_shape());
      |                               ^                   ~~~~~~~~~~~~~~~~~~~~~~~~~~

This issue is fixed but I see some TF layer tests are failing. I am not sure if this is related to the changes of this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: Python API OpenVINO Python bindings category: PyTorch FE OpenVINO PyTorch Frontend Code Freeze
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants