Implemented CPU plugin just-in-time emitter for NotEqual operation. #28257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a-sidorova
reviewed
Jan 3, 2025
There was a problem hiding this comment.
@geeky33 Thank you for the contribution! Please take a look at the failed Code-Style job and my single comment 😊
src/plugins/intel_cpu/src/emitters/plugin/aarch64/jit_eltwise_emitters.cpp
Outdated
Show resolved
Hide resolved
|
build_jenkins |
|
@a-sidorova ma'am I have updated the code please review it :) |
|
@geeky33 the code styles checks are failed still. Could you take a look at them please again? |
|
@geeky33 seems like code-stile job is still red... Could you fix it again? Hint: you can configure OpenVINO with cmake key |
|
build_jenkins |
|
build_jenkins |
a-sidorova
approved these changes
Jan 29, 2025
|
build_jenkins |
|
build_jenkins |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details:
Added NotEqual Operation JIT Emitter for ARM64 SIMD
Implemented fp32 NotEqual operation JIT emitter for ARM64 SIMD platform using NEON instructions for optimized element-wise comparison operations. Added new NotEqualEmitter class and integrated with ARM64 executor and kernel (modified create_eltwise_emitter and get_supported_precisions).
Included comprehensive unit tests and performance benchmarks. Verified against reference CPU implementation with proper handling of edge cases (NaN, infinity, denormals).
No breaking changes. Requires ARM64 platform with NEON SIMD support.
Tickets: