Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Good First Issue] [ARM]: Implement CPU plugin just-in-time emitter for NotEqual operation #27516

Closed
a-sidorova opened this issue Nov 12, 2024 · 5 comments · Fixed by #28257
Closed

[Good First Issue] [ARM]: Implement CPU plugin just-in-time emitter for NotEqual operation #27516

a-sidorova opened this issue Nov 12, 2024 · 5 comments · Fixed by #28257
Assignees
@geeky33
Labels
category: CPU OpenVINO CPU plugin good first issue Good for newcomers platform: arm OpenVINO on ARM / ARM64

Comments

@a-sidorova
Copy link
Contributor

Context

JIT Emitters are part of code generation feature (a.k.a. tensor compiler) that automatically produces highly-efficient optimized fused subgraph binary code. Each emitter implements specific operation from low level OpenVINO dialect.

Prerequisites

Recommended to use ARM CPU based platform for development (e.g. Mac, Raspberry Pi etc). Emulators (e.g. QEMU) is still an option, but not that convenient, especially for final performance evaluation.

What needs to be done?

Tests

Tests are disabled in default build, so ensure to add -DENABLE_TESTS=ON into cmake command.

GoogleTest is used for testing. CPU functional test target is ov_cpu_func_tests. You can use GoogleTest filter:

./bin/[platform]/[build_type]/ov_cpu_func_tests --gtest_filter="*smoke*Comparison*NotEqual*"

Example Pull Requests

Resources

Contact points

@a-sidorova, @dmitry-gorokhov
@a-sidorova a-sidorova added good first issue Good for newcomers category: CPU OpenVINO CPU plugin platform: arm OpenVINO on ARM / ARM64 labels Nov 12, 2024
@github-project-automation github-project-automation bot moved this to Contributors Needed in Good first issues Nov 12, 2024
@manojks1999
Copy link

@a-sidorova , Can I work on this ?

@a-sidorova
Copy link
Contributor Author

@manojks1999 yes, you can. I assigned you. Feel free to ask if you have any questions 😊

@a-sidorova a-sidorova moved this from Contributors Needed to Assigned in Good first issues Nov 16, 2024
@manojks1999 manojks1999 mentioned this issue Nov 18, 2024
Closed
@manojks1999
Copy link

Hi @a-sidorova, can you help how can I test this on the local machine(Mac m1)?

@dmitry-gorokhov
Copy link
Contributor

@manojks1999 Please check Tests section in the description
image

@a-sidorova a-sidorova linked a pull request Nov 21, 2024 that will close this issue
[CPU] [ARM64] JIT not equal operation #27600
Closed
@a-sidorova a-sidorova moved this from Assigned to In Review in Good first issues Nov 26, 2024
@geeky33
Copy link
Contributor

geeky33 commented Dec 28, 2024

.take

@a-sidorova a-sidorova assigned geeky33 and unassigned manojks1999 Dec 28, 2024
@a-sidorova a-sidorova moved this from In Review to Assigned in Good first issues Dec 28, 2024
@a-sidorova a-sidorova removed a link to a pull request Dec 28, 2024
[CPU] [ARM64] JIT not equal operation #27600
Closed
@openvinotoolkit openvinotoolkit deleted a comment from github-actions bot Dec 28, 2024
@geeky33 geeky33 mentioned this issue Jan 2, 2025
Merged
@a-sidorova a-sidorova linked a pull request Jan 3, 2025 that will close this issue
Implemented CPU plugin just-in-time emitter for NotEqual operation. #28257
Merged
@a-sidorova a-sidorova moved this from Assigned to In Review in Good first issues Jan 3, 2025
github-merge-queue bot pushed a commit that referenced this issue Jan 30, 2025
@geeky33
Implemented CPU plugin just-in-time emitter for NotEqual operation. (#…
aa274e4 
…28257)

### Details:
# Added NotEqual Operation JIT Emitter for ARM64 SIMD

Implemented fp32 NotEqual operation JIT emitter for ARM64 SIMD platform
using NEON instructions for optimized element-wise comparison
operations. Added new NotEqualEmitter class and integrated with ARM64
executor and kernel (modified create_eltwise_emitter and
get_supported_precisions).

Included comprehensive unit tests and performance benchmarks. Verified
against reference CPU implementation with proper handling of edge cases
(NaN, infinity, denormals).

No breaking changes. Requires ARM64 platform with NEON SIMD support.

### Tickets:
 - *#27516*
@github-project-automation github-project-automation bot moved this from In Review to Closed in Good first issues Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geeky33 geeky33

Labels
category: CPU OpenVINO CPU plugin good first issue Good for newcomers platform: arm OpenVINO on ARM / ARM64
Projects
Good first issues
Status: Closed
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implemented CPU plugin just-in-time emitter for NotEqual operation. geeky33/openvino
4 participants
@dmitry-gorokhov @a-sidorova @manojks1999 @geeky33