diff --git a/.github/dockerfiles/ov_build/ubuntu_22_04_x64_cc/Dockerfile b/.github/dockerfiles/ov_build/ubuntu_22_04_x64_cc/Dockerfile index 07f0941fb441fa..f4c9fa726eafb7 100644 --- a/.github/dockerfiles/ov_build/ubuntu_22_04_x64_cc/Dockerfile +++ b/.github/dockerfiles/ov_build/ubuntu_22_04_x64_cc/Dockerfile @@ -38,7 +38,7 @@ RUN apt-get update && \ # Compiler \ clang-15 \ # Static analyzer - clang-tidy-15 \ + clang-tidy-18 \ # clang-tidy uses clang-format as a dependency clang-format-15 \ && \ diff --git a/.github/dockerfiles/ov_build/ubuntu_24_04_x64/Dockerfile b/.github/dockerfiles/ov_build/ubuntu_24_04_x64/Dockerfile index bc72500dde74a1..82a51ffc0b175e 100644 --- a/.github/dockerfiles/ov_build/ubuntu_24_04_x64/Dockerfile +++ b/.github/dockerfiles/ov_build/ubuntu_24_04_x64/Dockerfile @@ -31,12 +31,6 @@ RUN apt-get update && \ python3-full \ # For Java API default-jdk \ - # Compiler \ - clang-18 \ - # Static analyzer - clang-tidy-18 \ - # clang-tidy uses clang-format as a dependency - clang-format-18 \ && \ rm -rf /var/lib/apt/lists/* @@ -46,12 +40,6 @@ RUN chmod +x /install_build_dependencies.sh && \ /install_build_dependencies.sh && \ rm -rf /var/lib/apt/lists/* -RUN update-alternatives --install /usr/bin/clang-format clang-format $(which clang-format-18) 100 && \ - update-alternatives --set clang-format $(which clang-format-18) - -RUN update-alternatives --install /usr/bin/clang-tidy clang-tidy $(which clang-tidy-18) 100 && \ - update-alternatives --set clang-tidy $(which clang-tidy-18) - # Install sccache ARG SCCACHE_VERSION="v0.7.5" ENV SCCACHE_HOME="/opt/sccache" \ diff --git a/cmake/developer_package/clang_tidy/clang_tidy.cmake b/cmake/developer_package/clang_tidy/clang_tidy.cmake index abad5c6f880c54..41dcb709c8953e 100644 --- a/cmake/developer_package/clang_tidy/clang_tidy.cmake +++ b/cmake/developer_package/clang_tidy/clang_tidy.cmake @@ -3,23 +3,23 @@ # if(ENABLE_CLANG_TIDY) - set(CLANG_TIDY_REQUIRED_VERSION 15 CACHE STRING "Minimum clang-tidy version to use") - set(CLANG_TIDY_FILENAME clang-tidy) + set(CLANG_TIDY_REQUIRED_VERSION 18 CACHE STRING "clang-tidy version to use") + set(CLANG_TIDY_FILENAME clang-tidy-${CLANG_TIDY_REQUIRED_VERSION} clang-tidy) find_host_program(CLANG_TIDY NAMES ${CLANG_TIDY_FILENAME} PATHS ENV PATH) if(CLANG_TIDY) - execute_process(COMMAND ${CLANG_TIDY} --version OUTPUT_VARIABLE CLANG_VERSION) + execute_process(COMMAND ${CLANG_TIDY} ${CMAKE_CURRENT_SOURCE_DIR} ARGS --version OUTPUT_VARIABLE CLANG_VERSION) if(NOT CLANG_VERSION) - message(WARNING "Minimum supported clang-tidy version is ${CLANG_TIDY_REQUIRED_VERSION}!") + message(WARNING "Supported clang-tidy version is ${CLANG_TIDY_REQUIRED_VERSION}!") set(ENABLE_CLANG_TIDY OFF) else() - string(REGEX REPLACE ".*version ([0-9]+)\\..*" "\\1" CLANG_TIDY_MAJOR_VERSION ${CLANG_VERSION}) - if(CLANG_TIDY_MAJOR_VERSION LESS CLANG_TIDY_REQUIRED_VERSION) - message(WARNING "Minimum supported clang-tidy version is ${CLANG_TIDY_REQUIRED_VERSION}! Provided version ${CLANG_TIDY_MAJOR_VERSION}") + string(REGEX REPLACE "[^0-9]+([0-9]+)\\..*" "\\1" CLANG_TIDY_MAJOR_VERSION ${CLANG_VERSION}) + if(NOT CLANG_TIDY_MAJOR_VERSION EQUAL CLANG_TIDY_REQUIRED_VERSION) + message(WARNING "Supported clang-tidy version is ${CLANG_TIDY_REQUIRED_VERSION}! Provided version ${CLANG_TIDY_MAJOR_VERSION}") set(ENABLE_CLANG_TIDY OFF) endif() endif() else() - message(WARNING "clang-tidy is not found!") + message(WARNING "Supported clang-tidy-${CLANG_TIDY_REQUIRED_VERSION} is not found!") set(ENABLE_CLANG_TIDY OFF) endif() endif() diff --git a/cmake/developer_package/plugins/plugins.cmake b/cmake/developer_package/plugins/plugins.cmake index 19ccacd0310522..0cf7606f7e7f12 100644 --- a/cmake/developer_package/plugins/plugins.cmake +++ b/cmake/developer_package/plugins/plugins.cmake @@ -109,7 +109,7 @@ function(ov_add_plugin) if (OV_PLUGIN_ADD_CLANG_TIDY) if (ENABLE_CLANG_TIDY) set_target_properties(${OV_PLUGIN_NAME} PROPERTIES - CXX_CLANG_TIDY "clang-tidy;--extra-arg=-Wno-unused-command-line-argument") + CXX_CLANG_TIDY "clang-tidy-${CLANG_TIDY_REQUIRED_VERSION};--extra-arg=-Wno-unused-command-line-argument") endif() endif()