Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added definitions to contribute #97

Merged
merged 6 commits into from
May 29, 2020
Merged

Conversation

gregwhitworth
Copy link
Member

@gregwhitworth gregwhitworth commented May 27, 2020

I've updated the contribution document again. This time adding a terrible subnav at the top of the document but will hopefully allow people to jump down a bit quicker. Added in some anchors for sharing. Also added in some definitions for use across documents. The definition of a control is the important aspect as that is what is outlined in each of our specs as top level sections.

Also forced Home to be the first nav item.

This resolves #81

Copy link
Collaborator

@dandclark dandclark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one typo fix and some optional food for thought about the control definition.

@marcoscaceres
Copy link
Contributor

@gregwhitworth, you might need to rejoin the WICG (as either independent or... )... we look forward to having you back 🤗🤗🤗

@gregwhitworth gregwhitworth merged commit 545dab3 into master May 29, 2020
@gregwhitworth gregwhitworth deleted the gwhit-control-definition branch May 29, 2020 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Definition of a "control"?
4 participants