Add tabs proposal and research skeleton docs #183
Conversation
matthewp
requested review from
gregwhitworth and
levithomason
as code owners
1. Adds the heading to the proposal page. 2. Remove Working Draft from research page. 3. Removes Anatony section from research page.
|
Updated with the requested changes. |
|
I made some comments here mostly as notes to refer back to but this lgtm as a starting point for discussion and I think we should merge it. |
|
@gregwhitworth did you see @matthewp's changes, it looks like it resolved your review but it seems it says it is blocked on requested changes? I think that's you? |
|
@bkardell I try to get in at least 1-2 times a week to triage and review items. Ironically Wed is one of those pre-defined days. With regards to the review itself there is a discussion between @chrisdholt and @matthewp above. So I'm not going to sign off on that until a new issue is opened to track the potential resolutions. So actions here:
Thanks |
|
@gregwhitworth can you point to somewhere where this is guidance on how you'd like to do this stuff procedurally? My understanding was that this is a vague starting point on which there should be plenty of discussions, further work and issues opened against from lots of interested parties. I made notes here specifically so I could come back and open issues once it is merged and I have a thing to them point at. Pointing at file that only exists in a PR seems weird to me - but if that's what you want me to do I guess I can? |
|
@gregwhitworth sure thing - my feedback was primarily in response to a couple specific questions that came up. I think one is tentatively resolved unless there is push back and an issue is required (slots for interactive content at start/end of tab list). Aside from that, nothing blocking on my end here. |
|
@gregwhitworth I've updated the content based on feedback from @una, @bkardell and @chrisdholt. Additionally I've opened the below issues based on questions to be answered later:
That leaves this one review item that I'm not sure how to resolve yet: #183 (review) Otherwise (1) and (2) are complete. |
These are just skeletons and not filled out. Intend to iterate on these a little at a time.