Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(proposal): add Skeleton proposal #133

Closed

Conversation

assuncaocharles
Copy link
Contributor

Adds proposal for Skeleton

@assuncaocharles assuncaocharles changed the title [WIP] feat(proposal): add Skeleton proposal feat(proposal): add Skeleton proposal Jul 18, 2020
Copy link
Member

@gregwhitworth gregwhitworth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting this. Before this lands there needs to be a general discussion around agreement of landing a skeleton component into Open UI. Please file an issue.

Additionally, with each of the items that you've added it's important to clarify why within your research unless you have an issue that already has been resolved on. As outlined in the contribution page:

Gaining consensus on a change
Of course, merely documenting what exists does not necessarily make something a good design. For each normative change that you make to your spec proposal, open an issue to outline the change that you're proposing. You should provide any research to support the change(s) that you're proposing.

So for the anatomy, the attributes, etc - these are all normative changes. I'd recommend breaking it down like this into a few seperate issues:

  1. Skeleton component: Should Open UI adopt a skeleton component (outline what libs are using it, why it should be considered a cow path worth paving).
  2. Anatomy: Outline the anatomy, why you've designed it the way that you have
  3. Attributes: What the attributes do and the decisions that lead to you keeping them

If there were other items you decided to not put in the initial proposal, make sure to include that somewhere as well (in one of the above issues will work if it fits into that category)

Thanks again for the work on this and please let me know if you have any questions. And once the issues are open make sure to broadcast them on the discord channel.

@gregwhitworth
Copy link
Member

my review is pending resolution of issue #139

@assuncaocharles
Copy link
Contributor Author

assuncaocharles commented Aug 18, 2020

my review is pending resolution of issue #139

@gregwhitworth What can we do to close it?

@gregwhitworth
Copy link
Member

@gregwhitworth What can we do to close it?

As noted, let's discuss this on the next telecon and the outcome of that call will impact the review of this PR.

@una
Copy link
Collaborator

una commented Nov 18, 2020

Did we resolve to add the research here but not add it as an Open-UI component proposal?

@gregwhitworth
Copy link
Member

Did we resolve to add the research here but not add it as an Open-UI component proposal?

The agenda recap has the following resolution:

Land skeleton on definition and accessibility patterns but not anatomy, attributes or properties

So the research and proposal should go in but the anatomy should be removed. These changes have not been made, @assuncaocharles any chance you can do these?

@assuncaocharles
Copy link
Contributor Author

Did we resolve to add the research here but not add it as an Open-UI component proposal?

The agenda recap has the following resolution:

Land skeleton on definition and accessibility patterns but not anatomy, attributes or properties

So the research and proposal should go in but the anatomy should be removed. These changes have not been made, @assuncaocharles any chance you can do these?

@gregwhitworth anatomy removed

@assuncaocharles
Copy link
Contributor Author

@gregwhitworth Gentle reminder

Copy link
Member

@gregwhitworth gregwhitworth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The parts of skeleton-line and skeleton-shape no longer exist since the anatomy has been removed. The skeleton proposal's primary focus due to the resolution should be on the definition of what a skeleton concept is. Also provide the guidance on how to create an accessible skeleton.

So all properties, etc need to be removed.

- `<skeleton-line>` - retangular fluid element representing a line
- `<skeleton-shape>` - element representing a shape

### Content not allowed within the anatomy
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would love to see the aria information in this proposal that we received from the ARIA WG on making an accessible skeleton component

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

which information is that?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@assuncaocharles sorry for the delay - here it is: w3c/aria#1317 (comment)

@assuncaocharles assuncaocharles requested a review from una as a code owner November 26, 2020 17:31
@yoavweiss yoavweiss changed the base branch from master to main March 5, 2021 21:45
@gregwhitworth
Copy link
Member

@assuncaocharles friendly ping regarding this PR

@gregwhitworth
Copy link
Member

@assuncaocharles another friendly ping; I'll close it out and you can re-open it if you plan to pick this back up. Thanks again for the work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants