Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a standardized method for toggling type='password' fields #254

Open
summercms opened this issue Jan 24, 2021 · 4 comments
Open

Add a standardized method for toggling type='password' fields #254

summercms opened this issue Jan 24, 2021 · 4 comments
Labels
help wanted Extra attention is needed research This is for any issue that is related to open-ui research work stale

Comments

@summercms
Copy link

Add a standardized method for toggling type='password' fields

e.g.

image

Maybe adding an attribute to the element to turn on this function?

@gregwhitworth
Copy link
Member

Thanks for filing this. I made the password reveal proposal and the reason we abandoned it was due to the very reason of Open UI's existence.

To move this forward, I would LOVE to see a research and proposal page for a password control. This would allow us to define the anatomy and behaviors which will be very close to the proposal I made. There is however, a key distinction that Open UI is attempting to solve which is setting the stage for more control over styling. This was where I saw the proposal there fall apart, which was I couldn't replace the content and thus, replicate reveals that I saw on certain sites that used words rather than an icon. Likewise, in the proposal it would be clipped by the input.

So if we undertake this again we should have a solid spec in place and then build out on how we'll enable those scenarios mentioned above. Any interest in going after it @ayumi-cloud ?

@summercms
Copy link
Author

Since opening this issue, I've had a think about this topic. One thing being overlooked is the accessibility aspect! I was thinking the semantic mark up should be labelled as a button and have some sort of aria-label indicating it's function. I've seen examples where people have added a link to toggle between the password and text type fields and thought someone using a screen reader would come across a blank link in the middle of the form and get totally confused.

@gregwhitworth

So if we undertake this again we should have a solid spec in place and then build out on how we'll enable those scenarios mentioned above. Any interest in going after it @ayumi-cloud ?

I've read so many explainer spec's over the years! But I don't think I could put together a good enough one for you guys, plus I'm swamped in work right now and struggling to get some spare time!

@gregwhitworth gregwhitworth added help wanted Extra attention is needed research This is for any issue that is related to open-ui research work labels Feb 2, 2021
@github-actions
Copy link

There hasn't been any discussion on this issue for a while, so we're marking it as stale. If you choose to kick off the discussion again, we'll remove the 'stale' label.

@github-actions github-actions bot added the stale label Mar 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed research This is for any issue that is related to open-ui research work stale
Projects
None yet
Development

No branches or pull requests

3 participants