Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Breadcrumb] What should the visual break between items be called? #200

Open
chrisdholt opened this issue Oct 18, 2020 · 4 comments
Open
Labels
breadcrumb Any issue related to the breadcrumb component needs edits This is ready for edits to be made needs-champion This means that this issue needs someone to champion the solution forward stale

Comments

@chrisdholt
Copy link
Collaborator

The visual break between breadcrumb items is referred to across libraries as either a divider or a separator. There is no clear consensus among libraries, though the spec submitted (#165) does refer to this as "divider". For breaks within a menu, the W3C uses the word separator. This issue is intended to track and land on the best semantic representation for this part given the lack of consensus and similar concepts described in the W3C described as "separator".

@gregwhitworth gregwhitworth added the breadcrumb Any issue related to the breadcrumb component label Oct 19, 2020
@gregwhitworth gregwhitworth added the agenda+ Use this label if you'd like the topic to be added to the meeting agenda label Nov 4, 2020
@una
Copy link
Collaborator

una commented Nov 5, 2020

Currently these are usually pseudo elements that are a part of a breadcrumb "element". The "seperator" lives within the breadcrumb.

MDN:
Screen Shot 2020-11-05 at 2 39 20 PM

Etsy:
Screen Shot 2020-11-05 at 2 36 57 PM

Target:
Screen Shot 2020-11-05 at 2 36 07 PM

Fashionphile:
Screen Shot 2020-11-05 at 2 34 14 PM
Screen Shot 2020-11-05 at 2 22 18 PM

I find these very similar to ::marker for list items. I feel these could be a pseudo element that also applies to breadcrumb in a similar way that it applies to (and is styled on) li, instead of its own specified part.

@chrisdholt
Copy link
Collaborator Author

I very much agree with both points here - the name of "separator" and treating this more as a pseudo element. Currently the name in the spec I believe is "divider" and I believe the spec also treats the separator as a slotted element by default in the anatomy. It would be great to get resolution on the above from others so we can update accordingly.

@gregwhitworth
Copy link
Member

This was discussed in the last meeting and it was agreed upon that it should be treated as ::marker rather than that of another element entirely.

Resolved: Add a marker part to the breadcrumb child

@gregwhitworth gregwhitworth removed the agenda+ Use this label if you'd like the topic to be added to the meeting agenda label Nov 9, 2020
@github-actions
Copy link

There hasn't been any discussion on this issue for a while, so we're marking it as stale. If you choose to kick off the discussion again, we'll remove the 'stale' label.

@github-actions github-actions bot added the stale label Mar 19, 2022
@gregwhitworth gregwhitworth added needs edits This is ready for edits to be made needs-champion This means that this issue needs someone to champion the solution forward labels Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breadcrumb Any issue related to the breadcrumb component needs edits This is ready for edits to be made needs-champion This means that this issue needs someone to champion the solution forward stale
Projects
None yet
Development

No branches or pull requests

3 participants