Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tabs #182

Open
matthewp opened this issue Sep 30, 2020 · 12 comments
Open

Tabs #182

matthewp opened this issue Sep 30, 2020 · 12 comments
Labels
research This is for any issue that is related to open-ui research work stale Tabs This is issue is in relation to tab component issues

Comments

@matthewp
Copy link
Contributor

This issue is for standardizing tabs. A few people met today with mutual interest in advancing tabs. Based on my interpretation of that meeting the next steps are to:

  • Collaborate on implementation ideas
  • Create proposal and research docs here.

For the latter I've added skeleton docs here.

@gregwhitworth is it appropriate to submit a PR for these documents at this time or do we need to collaborate in a shared branch on these documents until a full proposal is ready.

@gregwhitworth
Copy link
Member

@matthewp for sure - PRs are welcome at any stage.

I've asked @brandonferrua to lend a hand here in gathering tabs research and get a research page up but if you intend to do that let us know and we can possibly dig into combobox/multi-select research. I'm going to cc @chrisdholt as well since him and I have discussed tabs in the past.

@gregwhitworth gregwhitworth added research This is for any issue that is related to open-ui research work Tabs This is issue is in relation to tab component issues labels Sep 30, 2020
@bkardell
Copy link
Collaborator

bkardell commented Oct 1, 2020

Since some of it is fairly basic and other stuff is going to require a lot more discussion once someone articulates something, I'm kind of inclined to let MS give us the initial thing rather than trying to recreate any of it... Unless I am mistaken, they already has a fair start on a lot of these items from Fast related work that just need transported over?

@chrisdholt
Copy link
Collaborator

Since some of it is fairly basic and other stuff is going to require a lot more discussion once someone articulates something, I'm kind of inclined to let MS give us the initial thing rather than trying to recreate any of it... Unless I am mistaken, they already has a fair start on a lot of these items from Fast related work that just need transported over?

I see this convo, and am going to try and get some ideas up here somewhere based on our spec soon. I think getting something up from what we've done will give folks the chance to kick it and improve, iterate, etc. Things have been a bit crazy, but I've cancelled a couple days worth of meetings tomorrow and over the next week. :)

@matthewp
Copy link
Contributor Author

matthewp commented Oct 2, 2020

@bkardell @chrisdholt You are both speaking about something without saying specifically what the it is. 😀 What is the thing that MS has that we should evaluate? A tabs implementation? A tabs spec? A brownie recipe? I'm on the edge of my seat to find out.

@bkardell
Copy link
Collaborator

bkardell commented Oct 2, 2020

@matthewp The 'it' is a document created actual initial information to fill in the skeleton. A lot of the answers (research links, primary use cases, etc) already exist over there in MS's work and don't have to be recollected or duplicated, they just need to be largely copied over to kick it off. Many of the 'parts' in tabs (not :part necessarily) are well defined by ARIA too, so much of this isn't in any way controversial. What will be harder is many of the actual other details beyond that (how many elements, what parts, what apis), but it's hard to talk about them until they are written down here and we have a filled in doc.

@gregwhitworth
Copy link
Member

@matthewp it's here: https://github.com/microsoft/fast/blob/master/packages/web-components/fast-foundation/src/tabs/tabs.spec.md

If you want to do the PR for @chrisdholt to start there and transfer their learnings and open issues against them based on yours I think it'll help out.

@matthewp
Copy link
Contributor Author

matthewp commented Oct 2, 2020

Happy to do it if it's ok with @chrisdholt, don't want to steal credit from anyone.

@chrisdholt
Copy link
Collaborator

Happy to do it if it's ok with @chrisdholt, don't want to steal credit from anyone.

@matthewp Feel free to kick it off; that will certainly accelerate things. Our goal with our specs is to have a starting point for our implementation, but we've also wanted to align them to the Open UI definition and "upstream" them. As alignment takes and consensus takes place here, we'll work to prioritize and update our implementations. Happy to have you kick this off. Please do let me know when it's up and that way I can keep an eye out and provide feedback or context, reasoning, etc for certain decisions.

@matthewp
Copy link
Contributor Author

matthewp commented Oct 2, 2020

@gregwhitworth My PR is updated with the information from the FAST design tabs: #183

@summercms
Copy link

summercms commented Dec 8, 2020

Something we have done in our cms, was adding lazyloading to tabs, which increased performance for all themes and plugins.

It would be kind of nice if that was rolled out to tabs in a standardized form.

Wasn't sure to add to this issue or open a separate issue found here: #238

@bkardell
Copy link
Collaborator

bkardell commented Jan 4, 2021

Just wanted to add that in the interest of working more quickly and collaboratively, a few of us have been collecting information in a google doc which we will clean up and reformat/move here as it gets somewhere - but also in the interest of not stepping on anyone else, I thought it would make sense to share this research we've been collecting and let anyone else add to or help move over, etc. You can find it at https://docs.google.com/document/d/1c5aufvMkuGtFGCKc4fVmqPcBKqnB7alFYro1HB9TOU0/edit?usp=sharing

@github-actions
Copy link

There hasn't been any discussion on this issue for a while, so we're marking it as stale. If you choose to kick off the discussion again, we'll remove the 'stale' label.

@github-actions github-actions bot added the stale label Mar 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
research This is for any issue that is related to open-ui research work stale Tabs This is issue is in relation to tab component issues
Projects
None yet
Development

No branches or pull requests

5 participants