Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop target for <input type=file> #173

Open
mrmckeb opened this issue Sep 13, 2020 · 4 comments
Open

Drop target for <input type=file> #173

mrmckeb opened this issue Sep 13, 2020 · 4 comments
Labels

Comments

@mrmckeb
Copy link
Collaborator

mrmckeb commented Sep 13, 2020

This issue comes from this comment: #140 (comment)

When testing browser implementations, only Firefox had the container set as the drop target.

Feature Chrome Firefox Safari
Drag and drop
Drop target Button Input Button

The table below assesses the libraries and websites discussed in #114 (where input refers to the containing element).

Feature MOJ GitHub Ant Design Carbon Evergreen Materialise Bootstrap
Drag and drop Optional Optional
Drop target Input Input Input Button Input Input

Based on this research, I propose that we move forward with the recommendation that the drop target is set to the containing element.

@gregwhitworth gregwhitworth added the agenda+ Use this label if you'd like the topic to be added to the meeting agenda label Sep 22, 2020
@gregwhitworth gregwhitworth removed the agenda+ Use this label if you'd like the topic to be added to the meeting agenda label Oct 8, 2020
@gregwhitworth
Copy link
Member

This was just discussed in the telecon and there was a resolution to make the drop target the containing host element. Minutes are here: https://www.w3.org/2020/10/08-openui-minutes.html

That said, there was confusion on the part of label so we'll be opening an issue to clarify that name as folks on the call had feedback regarding it.

@gregwhitworth
Copy link
Member

Grr, pushed the wrong button - re-opening so @mrmckeb can close as when the change has been made

@mrmckeb
Copy link
Collaborator Author

mrmckeb commented Oct 12, 2020

@gregwhitworth were there any suggestions? I didn't see any in the minutes.

Perhaps "description" or "details"? It could be "filename" but it only shows the filename when uploading a single file.

@github-actions
Copy link

There hasn't been any discussion on this issue for a while, so we're marking it as stale. If you choose to kick off the discussion again, we'll remove the 'stale' label.

@github-actions github-actions bot added the stale label Mar 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants