Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify button part behavior for <select multiple>? #142

Open
dandclark opened this issue Jul 23, 2020 · 3 comments
Open

Modify button part behavior for <select multiple>? #142

dandclark opened this issue Jul 23, 2020 · 3 comments
Labels
select-v2 Features regarding the second iteration of the selectmenu element stale

Comments

@dandclark
Copy link
Collaborator

In the <select> anatomy, there are a couple of spots where we don't modify open or aria-expanded if the multiple attribute is set, e.g. see listbox keydown(enter). However for button there's nothing to indicate that it should not toggle these attributes, or that it should not appear at all, if multiple is present. So there's an inconsistency here.

Adding an extra layer of difficulty is the fact that for Safari/Chrome/Edge on iOS there is actually still a visible button for <select multiple> that opens a popover with checkable options. So, the button not affecting the open state of the popup if multiple is set isn't even universally true if we consider iOS.

@github-actions
Copy link

There hasn't been any discussion on this issue for a while, so we're marking it as stale. If you choose to kick off the discussion again, we'll remove the 'stale' label.

@github-actions github-actions bot added the stale label Mar 20, 2022
@josepharhar josepharhar added select-v2 Features regarding the second iteration of the selectmenu element and removed select These are issues that relate to the select component labels Feb 16, 2023
@josepharhar
Copy link
Collaborator

I think that multi select will have a button and a popup, in which case we won't have to do anything differently with the button.

@github-actions github-actions bot removed the stale label Mar 22, 2024
Copy link

There hasn't been any discussion on this issue for a while, so we're marking it as stale. If you choose to kick off the discussion again, we'll remove the 'stale' label.

@github-actions github-actions bot added the stale label Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
select-v2 Features regarding the second iteration of the selectmenu element stale
Projects
None yet
Development

No branches or pull requests

2 participants