Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: undo test case config changes #2836

Merged
merged 1 commit into from
Jan 22, 2025
Merged

Conversation

zzcr
Copy link
Member

@zzcr zzcr commented Jan 22, 2025

PR

撤销测试用例配置修改

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our Commit Message Guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Summary by CodeRabbit

  • Configuration
    • Updated default viewport size for Chromium tests from 1600x960 to 1080x720.

Copy link

coderabbitai bot commented Jan 22, 2025

Walkthrough

The pull request involves a modification to the Playwright configuration in the internals/playwright-config/src/index.js file. Specifically, the viewport dimensions for the 'chromium' project have been adjusted from 1600x960 to 1080x720, changing the screen resolution for test execution.

Changes

File Change Summary
internals/playwright-config/src/index.js Updated viewport settings for 'chromium' project from 1600x960 to 1080x720

Possibly related PRs

Suggested labels

chore

Suggested reviewers

  • kagol

Poem

🐰 A viewport tweak, so small and neat,
Pixels dancing to a different beat
From sixteen-hundred down to ten-eighty's frame
Our tests will run with a resolution's new aim
Playwright config, subtly refined! 🖥️


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d6d2ac7 and a581f87.

📒 Files selected for processing (1)
  • internals/playwright-config/src/index.js (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: PR Unit Test
🔇 Additional comments (2)
internals/playwright-config/src/index.js (2)

67-69: Configuration looks good!

The new viewport dimensions (1080x720) provide a reasonable desktop testing resolution while maintaining a good balance with the mobile device testing configurations.


68-68: Verify impact on existing visual regression tests.

The viewport change from 1600x960 to 1080x720 could affect existing screenshot-based tests. This resolution is closer to common desktop viewport sizes, but may require updating baseline screenshots.

Run this script to identify potentially affected visual regression tests:

✅ Verification successful

Viewport changes are safe to proceed

The codebase shows no evidence of visual regression testing or screenshot-based assertions that could be affected by this viewport change. The new dimensions (1080x720) align well with common desktop testing resolutions.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Find screenshot tests that might need updates due to viewport changes

# Search for screenshot assertions in test files
rg -l 'toHaveScreenshot|screenshot' -g '*.{spec,test}.{js,ts}'

# Search for existing screenshot baselines
fd -g '*.png' -p '*-snapshots*'

Length of output: 198


Script:

#!/bin/bash
# Description: Broader search for visual testing related files and configurations

# Check package.json files for visual testing related dependencies
echo "=== Checking package.json files for visual testing dependencies ==="
fd package.json --type f --exec jq -r '.dependencies,.devDependencies | select(. != null) | keys[]' {} | grep -iE 'visual|screenshot|image|percy'

# Search for screenshot/visual test related patterns with more context
echo -e "\n=== Searching for visual test related patterns ==="
rg -l -g '!node_modules' -g '!dist' -g '!build' -i 'visual|screenshot|snapshot|image.*(test|spec)'

# Find snapshot directories with common naming patterns
echo -e "\n=== Looking for snapshot directories ==="
fd -t d -g '*snapshot*' -g '*visual*' -g '*screenshots*'

Length of output: 3931

✨ Finishing Touches
  • 📝 Generate Docstrings (Beta)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added the chore label Jan 22, 2025
Copy link

Walkthrough

This pull request reverts changes made to the test case configuration, specifically adjusting the viewport dimensions for the Chromium browser in the Playwright configuration.

Changes

File Summary
internals/playwright-config/src/index.js Changed viewport dimensions from 1600x960 to 1080x720 for Chromium in Playwright configuration.

@@ -65,7 +65,7 @@ const Config = ({ testDir, baseURL, storageState, devServerCommon }) =>
name: 'chromium',
use: {
...devices['Desktop Chrome'],
viewport: { width: 1600, height: 960 }
viewport: { width: 1080, height: 720 }

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The viewport dimensions have been changed from 1600x960 to 1080x720. Ensure that this change aligns with the intended test scenarios and does not inadvertently affect test coverage or accuracy.

Copy link

[e2e-test-warn]
The component to be tested is missing.

The title of the Pull request should look like "fix(vue-renderless): [action-menu, alert] fix xxx bug".

Please make sure you've read our contributing guide

@kagol kagol merged commit f5a7a29 into dev Jan 22, 2025
14 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants