Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure remove button is functional for newly added menu items #113

Closed
wants to merge 2 commits into from
Closed

Conversation

dhmello
Copy link

@dhmello dhmello commented Aug 24, 2024

Description

This update addresses an issue where the remove button was not appearing or functioning correctly for newly added menu items in the menu management interface. The JavaScript responsible for adding new menu fields has been enhanced to ensure that each new item includes a functional remove button. Additionally, event listeners are properly attached to the remove buttons of both existing and newly added menu items, ensuring consistent behavior across all items. This fix improves the user experience by allowing seamless removal of menu items during customization.

Behaviour

Actual

When adding a new menu item through the menu management interface, the remove button is not properly displayed or functional. Users are unable to remove newly added menu items, causing frustration and hindering the menu customization process.

Expected

The newly added menu item should display a functional remove button, similar to existing menu items, allowing users to remove the item if desired.

Fixes #112

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality not to work as expected)
  • This change requires a documentation update

How Has This Been Tested

Test Configuration:

  • MyAAC Version: (latest: 0.8.16)
  • Browser:
    • Chrome
    • Opera
    • Firefox
    • Safari
    • Edge
    • Other
  • Operating System:
    • Windows
    • Ubuntu
    • MacOS
    • Other

Checklist

  • I've created separated branch from main updated
  • My code follows the style guidelines of this project
  • I followed project rules, best practices, and code indentation
  • I have performed a self-review of my own code
  • I checked the PR checks reports
  • I have commented on my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

This update addresses an issue where the remove button was not appearing or functioning correctly for newly added menu items in the menu management interface. The JavaScript responsible for adding new menu fields has been enhanced to ensure that each new item includes a functional remove button. Additionally, event listeners are properly attached to the remove buttons of both existing and newly added menu items, ensuring consistent behavior across all items. This fix improves the user experience by allowing seamless removal of menu items during customization.
@majestyotbr majestyotbr changed the title Fix: Ensure Remove Button is Functional for Newly Added Menu Items fix: ensure remove button is functional for newly added menu items Aug 25, 2024
@dhmello dhmello closed this by deleting the head repository Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove Button Not Functional for Newly Added Menu Items
1 participant