[mdns-avahi] utilize Avahi events for complete result handling #2742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2742 +/- ##
===========================================
- Coverage 55.77% 42.11% -13.66%
===========================================
Files 87 110 +23
Lines 6890 13391 +6501
Branches 0 954 +954
===========================================
+ Hits 3843 5640 +1797
- Misses 3047 7452 +4405
- Partials 0 299 +299 ☔ View full report in Codecov by Sentry. |
This commit enhances `Mdns::Publisher` using Avahi to utilize the events `AVAHI_BROWSER_ALL_FOR_NOW` , which notify that all records have been processed and no further results are expected in the near future. This improvement prevents premature "resolved" callbacks after receiving only the initial IPv6 address, thereby improving host and service address resolution. The `Publisher` now waits for these events to ensure it gathers all available addresses from the cache and query responses before signaling resolved callback.
abtink
force-pushed
the
avahi/event-multi-result
branch
from
ba3a15b to
17e8459
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit enhances
Mdns::Publisherusing Avahi to utilize the eventsAVAHI_BROWSER_ALL_FOR_NOWandCACHE_EXHAUSTED, which notify that all records have been processed and no further results are expected in the near future.This improvement prevents premature "resolved" callbacks after receiving only the initial IPv6 address, thereby improving host and service address resolution. The
Publishernow waits for these events to ensure it gathers all available addresses from the cache and query responses before signaling resolved callback.