Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ncp] add handling for unused properties to avoid warning logs #2740

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Irving-cl
Copy link
Contributor

This PR adds handling for some NCP properites.

Currently theere are some logs like:

2025-02-27T10:57:03.981495+08:00 otbr-agent[424273]: [CRIT]-NcpSpin-: Received unexpected response with (cmd:6, key:0), waiting (cmd:3, key:2353) for tid:3

2025-02-27T02:38:29.478937+00:00 rpi-4 otbr-agent[6900]: [WARN]-NcpSpin-: Received uncognized key: 5389
2025-02-27T02:38:29.479525+00:00 rpi-4 otbr-agent[6900]: [WARN]-NcpSpin-: Received uncognized key: 90
2025-02-27T02:38:29.480519+00:00 rpi-4 otbr-agent[6900]: [WARN]-NcpSpin-: Received uncognized key: 91

This PR adds handling for these properties to avoid these warning logs. For unsolicited notification cases, add case for these properties to avoid that they go to the default case and emit warnings.

Copy link

Important

The terms of service for this installation has not been accepted. Please ask the Organization owners to visit the Gemini Code Assist Admin Console to sign it.

Copy link

codecov bot commented Feb 27, 2025

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.

Project coverage is 43.74%. Comparing base (2b41187) to head (44edbdb).
Report is 962 commits behind head on main.

Files with missing lines Patch % Lines
src/host/ncp_spinel.cpp 0.00% 7 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2740       +/-   ##
===========================================
- Coverage   55.77%   43.74%   -12.04%     
===========================================
  Files          87      110       +23     
  Lines        6890    13408     +6518     
  Branches        0      954      +954     
===========================================
+ Hits         3843     5865     +2022     
- Misses       3047     7238     +4191     
- Partials        0      305      +305     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant