[border agent] refactor border agent to use MeshCoP Service state changed callback #2727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Irving-cl
force-pushed
the
thread_host_ba_api
branch
from
45acb51 to
b397c9f
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2727 +/- ##
===========================================
- Coverage 55.77% 43.46% -12.32%
===========================================
Files 87 110 +23
Lines 6890 13370 +6480
Branches 0 951 +951
===========================================
+ Hits 3843 5811 +1968
- Misses 3047 7254 +4207
- Partials 0 305 +305 ☔ View full report in Codecov by Sentry. |
|
Pending on the this PR in openthread: openthread/openthread#11276 |
Irving-cl
force-pushed
the
thread_host_ba_api
branch
from
b397c9f to
2549dcf
Compare
Irving-cl
force-pushed
the
thread_host_ba_api
branch
3 times, most recently
from
17e8bd6 to
507e833
Compare
Irving-cl
force-pushed
the
thread_host_ba_api
branch
from
507e833 to
d9c61db
Compare
|
Pending on openthread/openthread#11310 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the BorderAgent module to use the new MeshCoP service state changed callback.
Following openthread/openthread#11215, this PR uses the new MeshCoP service state changed callback to obtain the border agent state, udp port and MeshCoP Txt values. With this PR, the BorderAgent module doesn't need to assemble Txt values from OT itself nor need to subscribe to various Thread state change.
This PR is also intended to decouple the BorderAgent module with OT instance (the RCP architecture) and make it can also work for the NCP architecture.
A new ThreadHost API
BorderAgentSetMeshCoPServiceChangedCallbackis added. In the RCP implementation, it simply usesotBorderAgentSetMeshCoPServiceChangedCallback. The NCP implementation will be added later. This API is invoked to connect the BorderAgent module with the MeshCoP service state change.This PR also updates the DBus method 'Get/SetEphemeralKey' implementation to use OT API because with the new design the bit indicating IsEphemeralKeyEnabled is managed by OT core.