Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test] fix socat version to 1.7.4.4 #2706

Merged
merged 1 commit into from
Feb 27, 2025

Conversation

Irving-cl
Copy link
Contributor

@Irving-cl Irving-cl commented Feb 11, 2025

This PR changes the installation of socat from using 'apt' to manual installation.

We found the latest socat version 1.8.0.3 has an issue when running with OTBR docker. To avoid the error caused by version and facilitate local development, the PR provides a script to install socat of version 1.7.4.4 and replaces the installation in CI and scripts..

BTW, the installation in install_openthread_binraries is unnecessary because install_common_dependencies will be done anyway.

Fixes: #2719

@Irving-cl Irving-cl requested review from bukepo and superwhd February 11, 2025 11:46
@Irving-cl Irving-cl force-pushed the fix_socat_version branch 2 times, most recently from e7a87d8 to aa37528 Compare February 11, 2025 11:52
@Irving-cl Irving-cl marked this pull request as draft February 11, 2025 11:55
Copy link

codecov bot commented Feb 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.57%. Comparing base (2b41187) to head (d9d1787).
Report is 962 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2706       +/-   ##
===========================================
- Coverage   55.77%   43.57%   -12.21%     
===========================================
  Files          87      110       +23     
  Lines        6890    13401     +6511     
  Branches        0      954      +954     
===========================================
+ Hits         3843     5839     +1996     
- Misses       3047     7255     +4208     
- Partials        0      307      +307     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Irving-cl Irving-cl force-pushed the fix_socat_version branch 2 times, most recently from 46379bc to 1c3f27f Compare February 27, 2025 02:33
@Irving-cl Irving-cl marked this pull request as ready for review February 27, 2025 04:48
Copy link
Contributor

@superwhd superwhd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Irving-cl Irving-cl requested a review from jwhui February 27, 2025 04:59
@jwhui jwhui merged commit bdb621c into openthread:main Feb 27, 2025
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OTBR docker image using simulation RCP crashed due to socat
4 participants