-
Notifications
You must be signed in to change notification settings - Fork 239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pd] deprecate old prefixes in radvd configuration on DHCPv6 PD change #2701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2701 +/- ##
===========================================
- Coverage 55.77% 43.56% -12.22%
===========================================
Files 87 110 +23
Lines 6890 13398 +6508
Branches 0 953 +953
===========================================
+ Hits 3843 5837 +1994
- Misses 3047 7254 +4207
- Partials 0 307 +307 ☔ View full report in Codecov by Sentry. |
…on changes: easier to read
superwhd
reviewed
Feb 13, 2025
…on changes: add TODO
superwhd
approved these changes
Feb 21, 2025
bukepo
reviewed
Feb 24, 2025
Co-authored-by: Yakun Xu <xyk@google.com>
4d1e86d
to
43bca34
Compare
bukepo
reviewed
Feb 24, 2025
Co-authored-by: Yakun Xu <xyk@google.com>
61c7d88
to
6e16f05
Compare
bukepo
approved these changes
Feb 25, 2025
jwhui
reviewed
Feb 25, 2025
jwhui
approved these changes
Feb 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses an issue where old prefixes were not being properly deprecated in the RADVD configuration when the upstream interface's delegated prefix changed. Previously, only the new prefix would be advertised, potentially leading to issues for OT still using the old prefix.
Now, upon a new PD message, dhcpcd.enter-hook will:
Identify the old and new prefixes: It retrieves the old and new prefix information from the dhcpcd environment variables.
Configure radvd to deprecate the old prefix: If an old prefix exists and is different from the new prefix, the radvd.conf file is updated to include the old prefix with a preferred and valid lifetime of 0. This signals to OT that the prefix is deprecated and should no longer be used.
Publish the new prefix: The new prefix is added to radvd.conf with the appropriate lifetimes received from the DHCPv6 server.
Reload radvd: The radvd service is reloaded to apply the changes.