-
Notifications
You must be signed in to change notification settings - Fork 239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[posix] add POSIX CLI daemon module #2676
Conversation
a34aa8a
to
4cc806f
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2676 +/- ##
===========================================
- Coverage 55.77% 43.60% -12.17%
===========================================
Files 87 110 +23
Lines 6890 13387 +6497
Branches 0 952 +952
===========================================
+ Hits 3843 5838 +1995
- Misses 3047 7242 +4195
- Partials 0 307 +307 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the quick implementation 👍
I have a few comments.
251470f
to
e74d5b0
Compare
e74d5b0
to
8a9e0cc
Compare
b133533
to
d95dc9c
Compare
d95dc9c
to
89c757f
Compare
de6e6e9
to
d0bdde4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Thanks for breaking it into small ones.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM overall
66e5031
to
b9057c5
Compare
b9057c5
to
b5e7645
Compare
This PR introduces the CLI daemon module for OTBR on POSIX in NCP mode. This initial implementation focuses on setting up the module and establishing the listen socket. Further CLI functionalities and integration with NcpHost will be implemented in subsequent PRs.